From: Andrey Smirnov <andrew.smirnov@gmail.com>
To: barebox@lists.infradead.org
Cc: Andrey Smirnov <andrew.smirnov@gmail.com>
Subject: [PATCH 3/3] ds1307: Configure ds1341 for lowest power mode
Date: Sun, 3 Apr 2016 18:06:33 -0700 [thread overview]
Message-ID: <1459731993-14807-3-git-send-email-andrew.smirnov@gmail.com> (raw)
In-Reply-To: <1459731993-14807-1-git-send-email-andrew.smirnov@gmail.com>
Empirical observations show that configuring INTCN=1, ECLK=0, EGFIL=0,
DOSF=1 on DS1341 put the chip in the mode where it draws the least
amount fo current.
Add code to configure DS1341 in such a way in case Barebox is the last
code that runs on the processor before being shut down.
Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
---
drivers/rtc/rtc-ds1307.c | 20 ++++++++++++++++----
1 file changed, 16 insertions(+), 4 deletions(-)
diff --git a/drivers/rtc/rtc-ds1307.c b/drivers/rtc/rtc-ds1307.c
index a1cfed6..4720964 100644
--- a/drivers/rtc/rtc-ds1307.c
+++ b/drivers/rtc/rtc-ds1307.c
@@ -68,6 +68,7 @@ enum ds_type {
#define DS1337_REG_CONTROL 0x0e
# define DS1337_BIT_nEOSC 0x80
# define DS1339_BIT_BBSQI 0x20
+# define DS1341_BIT_EGFIL 0x20
# define DS3231_BIT_BBSQW 0x40 /* same as BBSQI */
# define DS1337_BIT_RS2 0x10
# define DS1337_BIT_RS1 0x08
@@ -83,6 +84,7 @@ enum ds_type {
# define DS1340_BIT_OSF 0x80
#define DS1337_REG_STATUS 0x0f
# define DS1337_BIT_OSF 0x80
+# define DS1341_BIT_DOSF 0x40
# define DS1341_BIT_ECLK 0x04
# define DS1337_BIT_A2I 0x02
# define DS1337_BIT_A1I 0x01
@@ -333,12 +335,22 @@ static int ds1307_probe(struct device_d *dev)
i2c_smbus_write_byte_data(client, DS1337_REG_CONTROL,
ds1307->regs[0]);
- /*
- For the above to be true, DS1341 also has to have
- ECLK bit set to 0
- */
if (ds1307->type == ds_1341) {
+ /*
+ For the above to be true, DS1341 also has to have
+ ECLK bit set to 0
+ */
ds1307->regs[1] &= ~DS1341_BIT_ECLK;
+
+ /*
+ * Let's set additionale RTC bits to
+ * facilitate maximum power saving.
+ */
+ ds1307->regs[0] |= DS1341_BIT_DOSF;
+ ds1307->regs[0] &= ~DS1341_BIT_EGFIL;
+
+ i2c_smbus_write_byte_data(client, DS1337_REG_CONTROL,
+ ds1307->regs[0]);
i2c_smbus_write_byte_data(client, DS1337_REG_STATUS,
ds1307->regs[1]);
}
--
2.5.5
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2016-04-04 1:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-04 1:06 [PATCH 1/3] rtc: abracon: Check obtianed time for validity Andrey Smirnov
2016-04-04 1:06 ` [PATCH 2/3] ds1307: Fix a bug in probe() Andrey Smirnov
2016-04-04 1:06 ` Andrey Smirnov [this message]
2016-04-05 6:43 ` [PATCH 1/3] rtc: abracon: Check obtianed time for validity Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1459731993-14807-3-git-send-email-andrew.smirnov@gmail.com \
--to=andrew.smirnov@gmail.com \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox