mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Barebox List <barebox@lists.infradead.org>
Subject: [PATCH 4/6] bootm: fit: Print error when image is not signed
Date: Tue, 10 May 2016 16:08:07 +0200	[thread overview]
Message-ID: <1462889289-24215-4-git-send-email-s.hauer@pengutronix.de> (raw)
In-Reply-To: <1462889289-24215-1-git-send-email-s.hauer@pengutronix.de>

when fit is configured to force signed images then print an error
message when an unsigned image is opened to give the user a clue
what went wrong.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
 common/image-fit.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/common/image-fit.c b/common/image-fit.c
index a6e1082..ceb55c2 100644
--- a/common/image-fit.c
+++ b/common/image-fit.c
@@ -485,8 +485,11 @@ static int fit_open_configuration(struct fit_handle *handle, const char *name)
 				return ret;
 		}
 
-		if (ret < 0)
+		if (ret < 0) {
+			pr_err("configuration '%s': %s does not have a signature\n",
+			       unit, desc);
 			return ret;
+		}
 	}
 
 	if (of_property_read_string(conf_node, "kernel", &unit) == 0) {
-- 
2.8.0.rc3


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  parent reply	other threads:[~2016-05-10 14:08 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-10 14:08 [PATCH 1/6] bootm: Move bootm options to common/Kconfig Sascha Hauer
2016-05-10 14:08 ` [PATCH 2/6] bootm: Add missing BOOTM_FORCE_SIGNED_IMAGES option Sascha Hauer
2016-05-10 14:08 ` [PATCH 3/6] bootm: fit: Print error when image is not hashed Sascha Hauer
2016-05-10 14:08 ` Sascha Hauer [this message]
2016-05-10 14:08 ` [PATCH 5/6] bootm: set bootm_verify_mode to correct value Sascha Hauer
2016-05-10 14:08 ` [PATCH 6/6] bootm: Add verify mode "available" Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1462889289-24215-4-git-send-email-s.hauer@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox