From: Teresa Remmet <t.remmet@phytec.de>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH v2 3/4] commands: ubi: Add ubiupdatevol command
Date: Tue, 28 Jun 2016 13:17:34 +0200 [thread overview]
Message-ID: <1467112654.4482.14.camel@lws-tremmet.phytec.de> (raw)
In-Reply-To: <20160628054556.GG20657@pengutronix.de>
Hello Sascha,
Am Dienstag, den 28.06.2016, 07:45 +0200 schrieb Sascha Hauer:
> On Mon, Jun 27, 2016 at 01:42:19PM +0200, Teresa Remmet wrote:
> > Add ubiupdatevol command. This is to update static
> > and dynamic volumes.
> >
> > Signed-off-by: Teresa Remmet <t.remmet@phytec.de>
> > ---
> > Changes in v2:
> > - instead of using read_file, used a smaller
> > buffer and read/write in a loop
> >
> > commands/ubi.c | 81 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> > 1 file changed, 81 insertions(+)
> >
> > diff --git a/commands/ubi.c b/commands/ubi.c
> > index dc2b4b5..b8b3f38 100644
> > --- a/commands/ubi.c
> > +++ b/commands/ubi.c
> > @@ -7,10 +7,91 @@
> > #include <getopt.h>
> > #include <linux/mtd/mtd.h>
> > #include <linux/kernel.h>
> > +#include <linux/stat.h>
> > #include <linux/mtd/mtd-abi.h>
> > #include <mtd/ubi-user.h>
> > #include <mtd/ubi-media.h>
> >
> > +static int do_ubiupdatevol(int argc, char *argv[])
> > +{
> > + int fd_img, fd_vol, ret = 0;
> > + uint64_t size = 0;
> > + struct stat st;
> > + unsigned int count;
> > + void *buf;
> > +
> > + if (argc - optind < 2)
> > + return COMMAND_ERROR_USAGE;
> > +
> > + if (stat(argv[optind+1], &st)) {
> > + perror("stat image");
> > + return 1;
> > + }
> > +
> > + size = st.st_size;
>
> While applying I added a test that tests for FILESIZE_MAX here and bails
> out with an error.
I could add a check for FILESIZE_MAX and give a special error message in
this case. But we need a correct file size for static volumes. So tftp
server which do not pass the file size, will fail here.
Teresa
>
> Sascha
>
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2016-06-28 11:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-27 11:42 [PATCH v2 1/4] commands: ubimkvol: Add option for static volumes Teresa Remmet
2016-06-27 11:42 ` [PATCH v2 2/4] mtd: UBI: Add support for updating " Teresa Remmet
2016-06-27 11:42 ` [PATCH v2 3/4] commands: ubi: Add ubiupdatevol command Teresa Remmet
2016-06-28 5:45 ` Sascha Hauer
2016-06-28 11:17 ` Teresa Remmet [this message]
2016-06-27 11:42 ` [PATCH v2 4/4] ARM: am335x_defconfig: Enable ubi fastmap and ubifs Teresa Remmet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1467112654.4482.14.camel@lws-tremmet.phytec.de \
--to=t.remmet@phytec.de \
--cc=barebox@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox