From: Sascha Hauer <s.hauer@pengutronix.de>
To: Barebox List <barebox@lists.infradead.org>
Subject: [PATCH 1/3] nvvar: Simplify by using nv_set()
Date: Wed, 6 Jul 2016 10:20:25 +0200 [thread overview]
Message-ID: <1467793227-29416-2-git-send-email-s.hauer@pengutronix.de> (raw)
In-Reply-To: <1467793227-29416-1-git-send-email-s.hauer@pengutronix.de>
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
common/globalvar.c | 13 ++-----------
1 file changed, 2 insertions(+), 11 deletions(-)
diff --git a/common/globalvar.c b/common/globalvar.c
index 75e4d43..decd73c 100644
--- a/common/globalvar.c
+++ b/common/globalvar.c
@@ -124,19 +124,10 @@ int nvvar_add(const char *name, const char *value)
if (IS_ERR(p))
return PTR_ERR(p);
- if (value) {
- ret = dev_set_param(&global_device, name, value);
- if (ret)
- return ret;
- } else {
+ if (!value)
value = dev_get_param(&global_device, name);
- if (!value)
- value = "";
- }
-
- p->value = xstrdup(value);
- return nv_save(p->name, value);
+ return nv_set(&nv_device, p, value);
}
int nvvar_remove(const char *name)
--
2.8.1
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2016-07-06 8:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-06 8:20 Introduce non volatile device variables Sascha Hauer
2016-07-06 8:20 ` Sascha Hauer [this message]
2016-07-06 8:20 ` [PATCH 2/3] nvvar: Simplify by using dev_set_param() Sascha Hauer
2016-07-06 8:20 ` [PATCH 3/3] Introduce non volatile device variables Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1467793227-29416-2-git-send-email-s.hauer@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox