* [PATCH] net: phy: of_phy_register_fixed_link(): drop redundant initialization
@ 2016-08-18 11:20 Antony Pavlov
2016-08-22 5:47 ` Sascha Hauer
0 siblings, 1 reply; 2+ messages in thread
From: Antony Pavlov @ 2016-08-18 11:20 UTC (permalink / raw)
To: barebox
The phy_device_create() function makes all necessary phydev initialization
so we can drop phydev->pause and phydev->link initialization in
the of_phy_register_fixed_link() function.
Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
---
drivers/net/phy/phy.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c
index 13b8324..7132516 100644
--- a/drivers/net/phy/phy.c
+++ b/drivers/net/phy/phy.c
@@ -311,8 +311,6 @@ static struct phy_device *of_phy_register_fixed_link(struct device_node *np,
phydev->registered = 1;
phydev->speed = 1000;
phydev->duplex = 1;
- phydev->pause = phydev->asym_pause = 0;
- phydev->link = 1;
return phydev;
}
--
2.8.1
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] net: phy: of_phy_register_fixed_link(): drop redundant initialization
2016-08-18 11:20 [PATCH] net: phy: of_phy_register_fixed_link(): drop redundant initialization Antony Pavlov
@ 2016-08-22 5:47 ` Sascha Hauer
0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2016-08-22 5:47 UTC (permalink / raw)
To: Antony Pavlov; +Cc: barebox
On Thu, Aug 18, 2016 at 02:20:39PM +0300, Antony Pavlov wrote:
> The phy_device_create() function makes all necessary phydev initialization
> so we can drop phydev->pause and phydev->link initialization in
> the of_phy_register_fixed_link() function.
>
> Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
> ---
> drivers/net/phy/phy.c | 2 --
> 1 file changed, 2 deletions(-)
Applied, thanks
Sascha
>
> diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c
> index 13b8324..7132516 100644
> --- a/drivers/net/phy/phy.c
> +++ b/drivers/net/phy/phy.c
> @@ -311,8 +311,6 @@ static struct phy_device *of_phy_register_fixed_link(struct device_node *np,
> phydev->registered = 1;
> phydev->speed = 1000;
> phydev->duplex = 1;
> - phydev->pause = phydev->asym_pause = 0;
> - phydev->link = 1;
>
> return phydev;
> }
> --
> 2.8.1
>
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-08-22 5:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-18 11:20 [PATCH] net: phy: of_phy_register_fixed_link(): drop redundant initialization Antony Pavlov
2016-08-22 5:47 ` Sascha Hauer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox