From: Teresa Remmet <t.remmet@phytec.de>
To: barebox@lists.infradead.org
Subject: [PATCH 4/6] fs: Remove O_TRUNC check for devices when open files
Date: Fri, 25 Nov 2016 09:06:05 +0100 [thread overview]
Message-ID: <1480061167-21590-5-git-send-email-t.remmet@phytec.de> (raw)
In-Reply-To: <1480061167-21590-1-git-send-email-t.remmet@phytec.de>
Don't check for the file type here. Devices may have truncate
callbacks. Otherwise the caller should check if O_TRUNC is possible.
Signed-off-by: Teresa Remmet <t.remmet@phytec.de>
---
fs/fs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/fs.c b/fs/fs.c
index b7e7c63..2b4659c 100644
--- a/fs/fs.c
+++ b/fs/fs.c
@@ -682,7 +682,7 @@ int open(const char *pathname, int flags, ...)
if (ret)
goto out;
- if (!(s.st_mode & S_IFCHR) && (flags & O_TRUNC)) {
+ if (flags & O_TRUNC) {
ret = fsdrv->truncate(&fsdev->dev, f, 0);
f->size = 0;
if (ret)
--
1.9.1
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2016-11-25 8:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-25 8:06 [PATCH 0/6] ubi: remove character device flag from static volumes Teresa Remmet
2016-11-25 8:06 ` [PATCH 1/6] libfile: copy_file: Only open regular files with O_TRUNC Teresa Remmet
2016-11-25 8:06 ` [PATCH 2/6] devfs: Add optional truncate callback for device files Teresa Remmet
2016-11-25 8:06 ` [PATCH 3/6] ubi: Add truncate callback Teresa Remmet
2016-11-25 8:06 ` Teresa Remmet [this message]
2016-11-25 8:06 ` [PATCH 5/6] commands: ubi: ubiupdatevol: Open device with O_TRUNC Teresa Remmet
2016-11-25 8:06 ` [PATCH 6/6] ubi: barebox: Remove character device flag from static volumes Teresa Remmet
2016-12-07 20:13 ` [PATCH 0/6] ubi: remove " Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1480061167-21590-5-git-send-email-t.remmet@phytec.de \
--to=t.remmet@phytec.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox