From: iw3gtf@arcor.de
To: barebox@lists.infradead.org
Subject: problem configuring backlight brightness levels in device tree
Date: Mon, 11 Jul 2016 14:24:50 +0200 (CEST) [thread overview]
Message-ID: <1481832949.59258.1468239890158.JavaMail.ngmail@webmail22.arcor-online.net> (raw)
Hi,
I was trying to configure a pwm backlight on an embedded arm board
and I think I've found a minor problem.
In the source file 'drivers/video/backlight-pwm.c', in the function pwm_backlight_parse_dt()
you set the number of brightness values to:
pwm_backlight->backlight.brightness_max = length / sizeof(u32);
and then loop through the array with:
for (i = 0; i <= pwm_backlight->backlight.brightness_max; i++)
to find the max of the array.
I think the '<=' should be a '<' otherwise you access an uninitialized value
one past the end of the array; this actually does not directly crash barebox
but the whole brightness values are scaled wrong.
giorgio
Giorgio, iw3gtf@arcor.de
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next reply other threads:[~2016-07-11 13:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-11 12:24 iw3gtf [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-07-11 11:51 giorgio.nicole
2016-07-13 5:18 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1481832949.59258.1468239890158.JavaMail.ngmail@webmail22.arcor-online.net \
--to=iw3gtf@arcor.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox