From: Lucas Stach <l.stach@pengutronix.de>
To: Steffen Trumtrar <s.trumtrar@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH 6/8] efi: efi: load state from devicetree
Date: Wed, 05 Jul 2017 14:38:21 +0200 [thread overview]
Message-ID: <1499258301.22075.8.camel@pengutronix.de> (raw)
In-Reply-To: <20170705105637.4484-6-s.trumtrar@pengutronix.de>
Am Mittwoch, den 05.07.2017, 12:56 +0200 schrieb Steffen Trumtrar:
> Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
> ---
> common/efi/efi.c | 56 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 56 insertions(+)
>
> diff --git a/common/efi/efi.c b/common/efi/efi.c
> index f924385958e1..cc3051dedae9 100644
> --- a/common/efi/efi.c
> +++ b/common/efi/efi.c
> @@ -40,6 +40,8 @@
> #include <efi.h>
> #include <efi/efi.h>
> #include <efi/efi-device.h>
> +#include <libfile.h>
> +#include <state.h>
>
> efi_runtime_services_t *RT;
> efi_boot_services_t *BS;
> @@ -384,6 +386,60 @@ static int efi_postcore_init(void)
> }
> postcore_initcall(efi_postcore_init);
>
> +static int efi_late_init(void)
> +{
> + char *state_desc;
> + int ret;
> +
> + state_desc = xasprintf("/boot/EFI/barebox/state.dtb");
This might deserve a few sentences in the documentation, instead of
being buried in the code.
> + if (state_desc) {
> + void *fdt;
> + size_t size;
> + struct device_node *root = NULL;
> + struct device_node *np = NULL;
> + struct state *state;
> +
> + fdt = read_file(state_desc, &size);
> + if (!fdt) {
> + pr_err("unable to read %s: %s\n", state_desc,
> + strerror(errno));
> + return -errno;
> + }
> +
> + if (file_detect_type(fdt, size) != filetype_oftree) {
> + pr_err("%s is not an oftree file.\n", state_desc);
> + free(fdt);
> + return -EINVAL;
> + }
> +
> + root = of_unflatten_dtb(fdt);
> +
> + free(fdt);
> +
> + if (IS_ERR(root))
> + return PTR_ERR(root);
> +
> + of_set_root_node(root);
> +
> + np = of_find_node_by_alias(root, "state");
> +
> + state = state_new_from_node(np, NULL, 0, 0, false);
> + if (IS_ERR(state))
> + return PTR_ERR(state);
> +
> + ret = state_load(state);
> + if (ret)
> + pr_warn("Failed to load persistent state, continuing with defaults, %d\n",
> + ret);
> +
> + return 0;
> + }
> +
> + return 0;
> +}
> +late_initcall(efi_late_init);
> +
> static int do_efiexit(int argc, char *argv[])
> {
> return BS->exit(efi_parent_image, EFI_SUCCESS, 0, NULL);
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2017-07-05 12:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-05 10:56 [PATCH 1/8] state: fix compile warnings for dev_err expansion Steffen Trumtrar
2017-07-05 10:56 ` [PATCH 2/8] common: efi: do not use undefined kconfig option Steffen Trumtrar
2017-07-05 11:05 ` Lucas Stach
2017-07-06 7:31 ` Michael Olbrich
2017-07-05 10:56 ` [PATCH 3/8] fs: efi: return with correct error code in efifs_stat Steffen Trumtrar
2017-07-05 10:56 ` [PATCH 4/8] devfs-core: add function to find cdev by partuuid Steffen Trumtrar
2017-07-05 10:56 ` [PATCH 5/8] of: of_path: find device via partuuid Steffen Trumtrar
2017-07-05 10:56 ` [PATCH 6/8] efi: efi: load state from devicetree Steffen Trumtrar
2017-07-05 12:38 ` Lucas Stach [this message]
2017-07-05 10:56 ` [PATCH 7/8] blspec: skip all devicetree tests if entry doesn't specify one Steffen Trumtrar
2017-07-05 10:56 ` [PATCH 8/8] efi: efi: register barebox-update handler Steffen Trumtrar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1499258301.22075.8.camel@pengutronix.de \
--to=l.stach@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=s.trumtrar@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox