From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Mon, 11 Sep 2023 14:37:08 +0200 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qfgA9-00BUlf-OM for lore@lore.pengutronix.de; Mon, 11 Sep 2023 14:37:08 +0200 Received: from bombadil.infradead.org ([2607:7c80:54:3::133]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qfgA7-0004Vt-NM for lore@pengutronix.de; Mon, 11 Sep 2023 14:37:08 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=D1000e0ow/0wwjUi5O50TJAHF5pJFyZMNxawdSM27qk=; b=ZGRRNuTrK6UlSm64snb3Sq1ZW6 6YfejJzMakIsjV6QwmZrvl8K75VUAY28R6YVqieGHZryjQnV/I7o6dWRXMwSdN4oCqmPq13XuOWE6 U7MT601chvWJV5L0YULKA5AHyA1CwDZ5dctZPsqQxsV0uSAKlTKfwsPsLS8QnnYfMw4huAr+L+B9X TLqORsXGZkgi6gZxFpoXnwZwIqf85WOf+r50pAjM6+mIZEFFjTAI8A0rdppCguksv2SglqXodqSkv VvDobHhAEDenExK73evCpNXnSwIJAsKNKgswxZU6OKFgLWpPeBz7g8KuvfaXBOJryb1KkK8v6WfbN EEBYnXtQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qfg98-000UnV-09; Mon, 11 Sep 2023 12:36:06 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qfg95-000Umd-0J for barebox@lists.infradead.org; Mon, 11 Sep 2023 12:36:04 +0000 Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77] helo=[127.0.0.1]) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1qfg92-0004Jy-Hs; Mon, 11 Sep 2023 14:36:00 +0200 Message-ID: <14c4b608-2680-7296-b2fa-09b40f20dc08@pengutronix.de> Date: Mon, 11 Sep 2023 14:36:00 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Content-Language: en-US To: Marco Felsch Cc: barebox@lists.infradead.org, jzi@pengutronix.de References: <20230911122356.2709296-1-a.fatoum@pengutronix.de> <20230911122913.5ohz4nvm6lrq7ms5@pengutronix.de> From: Ahmad Fatoum In-Reply-To: <20230911122913.5ohz4nvm6lrq7ms5@pengutronix.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230911_053603_137247_40F2C770 X-CRM114-Status: GOOD ( 20.52 ) X-BeenThere: barebox@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "barebox" X-SA-Exim-Connect-IP: 2607:7c80:54:3::133 X-SA-Exim-Mail-From: barebox-bounces+lore=pengutronix.de@lists.infradead.org X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.whiteo.stw.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-5.6 required=4.0 tests=AWL,BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.2 Subject: Re: [PATCH] Documentation: dt-bindings: ocotp: deprecate barebox,provide-mac-address X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on metis.whiteo.stw.pengutronix.de) On 11.09.23 14:29, Marco Felsch wrote: > On 23-09-11, Ahmad Fatoum wrote: >> While we'll continue to support barebox,provide-mac-address, new boards >> should prefer using the upstream NVMEM binding for describing the MAC address. >> >> Add an example to the documentation. >> >> Signed-off-by: Ahmad Fatoum >> --- >> .../bindings/misc/fsl,imx-ocotp.rst | 25 ++++++++++++++++--- >> 1 file changed, 22 insertions(+), 3 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/misc/fsl,imx-ocotp.rst b/Documentation/devicetree/bindings/misc/fsl,imx-ocotp.rst >> index 202bb3aa07ef..1c45267b1b58 100644 >> --- a/Documentation/devicetree/bindings/misc/fsl,imx-ocotp.rst >> +++ b/Documentation/devicetree/bindings/misc/fsl,imx-ocotp.rst >> @@ -6,13 +6,14 @@ Required properties: >> * ``compatible``: ``fsl,imx6q-ocotp`` >> * ``reg``: physical register base and size >> >> -Optional properties: >> +Deprecated properties: >> >> * ``barebox,provide-mac-address``: Provide MAC addresses for Ethernet devices. This >> can be multiple entries in the form <&phandle regofs> to assign a MAC >> - address to an Ethernet device. >> + address to an Ethernet device. This has been deprecated in favor or the upstream >> + nvmem cell binding. >> >> -Example: >> +Legacy example: > > Do we still need to list it as example? Seems a bit odd for deprecated > bindings. It's useful to illustrate the difference to the NVMEM binding. Also deprecation might be a bit harsh. We will likely never remove support, but we'll try to curtail proliferation. Cheers, Ahmad > > Regards, > Marco > >> .. code-block:: none >> >> @@ -21,3 +22,21 @@ Example: >> reg = <0x021bc000 0x4000>; >> barebox,provide-mac-address = <&fec 0x620>; >> }; >> + >> +Upstream alternative: >> + >> +.. code-block:: none >> + >> + &ocotp1 { >> + #address-cells = <1>; >> + #size-cells = <1>; >> + >> + fec_mac_addr: mac-addr@88 { >> + reg = <0x88 6>; >> + }; >> + }; >> + >> + &fec { >> + nvmem-cells = <&fec_mac_addr>; >> + nvmem-cell-names = "mac-address"; >> + }; >> -- >> 2.39.2 >> >> >> > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |