[PATCH] video: tc358767: register aux i2c bus after validating link

[PATCH] video: tc358767: register aux i2c bus after validating link

[Andrey Gusakov]

Register AUX i2c adapter only if AUX link is functional. This
should avoid possible hung during tc358767 probe when no display
connected.

Signed-off-by: Andrey Gusakov <andrey.gusakov@cogentembedded.com>
---
 drivers/video/tc358767.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/video/tc358767.c b/drivers/video/tc358767.c
index f9ca06c..5ad5cb4 100644
--- a/drivers/video/tc358767.c
+++ b/drivers/video/tc358767.c
@@ -1404,6 +1404,10 @@ static int tc_probe(struct device_d *dev)
 	if (ret)
 		goto err;
 
+	ret = tc_get_display_props(tc);
+	if (ret)
+		goto err;
+
 	/* Register DP AUX channel */
 	tc->adapter.master_xfer = tc_aux_i2c_xfer;
 	tc->adapter.nr = -1; /* any free */
@@ -1416,10 +1420,6 @@ static int tc_probe(struct device_d *dev)
 		goto err;
 	}
 
-	ret = tc_get_display_props(tc);
-	if (ret)
-		goto err;
-
 	/* add vlp */
 	tc->vpl.node = dev->device_node;
 	tc->vpl.ioctl = tc_ioctl;
-- 
1.9.1


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] video: tc358767: register aux i2c bus after validating link

[Sascha Hauer]

On Mon, Mar 05, 2018 at 05:19:53PM +0300, Andrey Gusakov wrote:
> Register AUX i2c adapter only if AUX link is functional. This
> should avoid possible hung during tc358767 probe when no display
> connected.
> 
> Signed-off-by: Andrey Gusakov <andrey.gusakov@cogentembedded.com>
> ---
>  drivers/video/tc358767.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)

Applied, thanks

Sascha

> 
> diff --git a/drivers/video/tc358767.c b/drivers/video/tc358767.c
> index f9ca06c..5ad5cb4 100644
> --- a/drivers/video/tc358767.c
> +++ b/drivers/video/tc358767.c
> @@ -1404,6 +1404,10 @@ static int tc_probe(struct device_d *dev)
>  	if (ret)
>  		goto err;
>  
> +	ret = tc_get_display_props(tc);
> +	if (ret)
> +		goto err;
> +
>  	/* Register DP AUX channel */
>  	tc->adapter.master_xfer = tc_aux_i2c_xfer;
>  	tc->adapter.nr = -1; /* any free */
> @@ -1416,10 +1420,6 @@ static int tc_probe(struct device_d *dev)
>  		goto err;
>  	}
>  
> -	ret = tc_get_display_props(tc);
> -	if (ret)
> -		goto err;
> -
>  	/* add vlp */
>  	tc->vpl.node = dev->device_node;
>  	tc->vpl.ioctl = tc_ioctl;
> -- 
> 1.9.1
> 
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox