mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: "Jan Lübbe" <jlu@pengutronix.de>
To: barebox@lists.infradead.org
Subject: Re: [PATCH] blspec: add checking of optional key machine-id
Date: Thu, 03 May 2018 11:34:47 +0200	[thread overview]
Message-ID: <1525340087.17782.32.camel@pengutronix.de> (raw)
In-Reply-To: <9451da5b-d585-34cc-9d4d-c2645329b760@schmidt-andreas.de>

On Thu, 2018-05-03 at 10:42 +0200, Andreas Schmidt wrote:
> > Your use-case sound like you'd need a way to add a more specific DT
> > board compatible at runtime. 
> 
> We need a decision witch DT has to be load at runtime. But they are all
> compatible with the barebox DT. We have only one barebox DT for all devices.

Yes. So you have additional device declarations in the kernel device
trees, which are not relevant to barebox.

> > Then the existing selection logic would
> > handle your case as well.
> 
> Ohh ... ok. And could you explain please, who we could do that? Because,
> all our DTs are compatible with barebox DT and barebox would choose simple
> the first one and boot it. Or is using of Bootloader Spec isn't right
> way, to solve this issue?

So in the barebox DT you'd have:
/ {
        model = "Foo Common i.MX6 Board";
        compatible = "foo,mx6-common", "fsl,imx6q";
};
[...]

Then for the kernel DTs you can use different compatible lists, which
each use a different and more specific entry.

mx6-variant1.dts:
/ {
        model = "Foo Variant 1 i.MX6 Board";
        compatible =
"foo,mx6-variant1", "foo,mx6-common", "fsl,imx6q";
};
[...]

mx6-variant2.dts:
/ {
        model = "Foo Variant 2 i.MX6 Board";
        compatible = "foo,mx6-variant2", "foo,mx6-common", "fsl,imx6q";
};
[...]

Then, in barebox, you need to have a way to override which compatible
string the bootspec code is looking for.

I'd prefer this to the machine-id approach, as the DT compatible list
mechanism is designed exactly for handing these different levels of
compatibility declarations.

Regards,
Jan
-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2018-05-03  9:35 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-29 16:01 Andreas Schmidt
2018-05-02 11:02 ` Sascha Hauer
2018-05-02 13:23   ` [PATCH v2] " Andreas Schmidt
2018-05-08  6:13     ` Sascha Hauer
2018-05-02 14:32 ` [PATCH] " Jan Lübbe
2018-05-03  8:42   ` Andreas Schmidt
2018-05-03  9:34     ` Jan Lübbe [this message]
2018-05-03 15:31       ` Andreas Schmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1525340087.17782.32.camel@pengutronix.de \
    --to=jlu@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox