Re: [PATCH v1 2/2] fs/devfs: fix compile warnings

[Lucas Stach <l.stach@pengutronix.de>]

Am Mittwoch, den 17.10.2018, 11:44 +0200 schrieb Oleksij Rempel:
> This is the list of all warnings:

[...]

> Not sure if make sense to list all of them. Especially if you can see
> from the patch diff, what the patch is doing.

+1 for not polluting the commit message with all this noise. But I
think it would make sense to move the Wmissing-prototypes CFLAG out of
the mips architecture to apply it generally across all architectures,
so we don't introduce any more of those issues without noticing.

Regards,
Lucas


> Am 17.10.2018 um 11:22 schrieb Roland Hieber:
> > For both of these, it would be nice to know what the compiler warnings
> > were, in case anyone wants to grep the logs.
> > 
> >  - Roland
> > 
> > On Tue, Oct 16, 2018 at 09:50:22PM +0200, Oleksij Rempel wrote:
> > > > > > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> > > ---
> > >  fs/devfs.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/fs/devfs.c b/fs/devfs.c
> > > index d2b801036e..10f098280e 100644
> > > --- a/fs/devfs.c
> > > +++ b/fs/devfs.c
> > > @@ -193,7 +193,7 @@ static struct inode *devfs_alloc_inode(struct super_block *sb)
> > > > > >  	return &node->inode;
> > >  }
> > >  
> > > -int devfs_iterate(struct file *file, struct dir_context *ctx)
> > > +static int devfs_iterate(struct file *file, struct dir_context *ctx)
> > >  {
> > > > > >  	struct cdev *cdev;
> > >  
> > > -- 
> > > 2.19.0
> > > 
> > > 
> > > _______________________________________________
> > > barebox mailing list
> > > barebox@lists.infradead.org
> > > http://lists.infradead.org/mailman/listinfo/barebox
> > > 
> 
> 

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox