From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: Christian Eggers <ceggers@arri.de>, barebox@lists.infradead.org
Cc: ceggers@gmx.de
Subject: Re: [PATCH] bootchooser: Change name of kernel parameter
Date: Mon, 27 Jan 2020 09:31:02 +0100 [thread overview]
Message-ID: <153b40a5-3a31-da30-dfbb-9d2eeb82c426@pengutronix.de> (raw)
In-Reply-To: <20200127074639.17310-1-ceggers@arri.de>
Hello Christian,
On 1/27/20 8:46 AM, Christian Eggers wrote:
> When passing the target name as "bootchooser.active", Linux will not
> pass the parameter as environment variable to the init process. The only
> way to get the bootchooser result (e.g. in an initramfs), is to parse it
> out of /proc/cmdline (requires mounting of /proc, sed, ...).
>
> After renaming, the bootchooser result will be passed as environment
> variable which can easily accessed from /init (e.g. for selecting the
> associated root fs).
Existing userspace like RAUC[1] rely on this naming, so the default may
not be changed.
[1]: https://github.com/rauc/rauc/blob/f52978d9736f18794f7e277ca440e2e4e78c9703/src/context.c#L47
Cheers
Ahmad
>
> Signed-off-by: Christian Eggers <ceggers@arri.de>
> ---
> common/bootchooser.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/common/bootchooser.c b/common/bootchooser.c
> index c08db03eb..f0e3294dc 100644
> --- a/common/bootchooser.c
> +++ b/common/bootchooser.c
> @@ -817,7 +817,7 @@ static int bootchooser_boot_one(struct bootchooser *bc, int *tryagain)
> goto out;
> }
>
> - system = basprintf("bootchooser.active=%s", target->name);
> + system = basprintf("bootchooser_active=%s", target->name);
> globalvar_add_simple("linux.bootargs.bootchooser", system);
> free(system);
>
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next prev parent reply other threads:[~2020-01-27 8:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-27 7:46 Christian Eggers
2020-01-27 8:31 ` Ahmad Fatoum [this message]
2020-01-27 9:37 ` Christian Eggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=153b40a5-3a31-da30-dfbb-9d2eeb82c426@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=ceggers@arri.de \
--cc=ceggers@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox