From: Stefan Riedmueller <s.riedmueller@phytec.de>
To: barebox@lists.infradead.org
Cc: Jan Remmet <j.remmet@phytec.de>
Subject: [PATCH] phytec-som-imx6: ksz8081_phy_fixup: Don't override B-CAST_OFF strap-in
Date: Tue, 4 Dec 2018 11:43:45 +0100 [thread overview]
Message-ID: <1543920225-20866-1-git-send-email-s.riedmueller@phytec.de> (raw)
From: Jan Remmet <j.remmet@phytec.de>
As PHY address 0 is not used on PHYTEC i.MX 6 and i.MX 6UL SOMs we do
not have to override the B-CAST_OFF strap-in which disables broadcast
on PHY address 0.
Also add some comments about the magic values.
Signed-off-by: Jan Remmet <j.remmet@phytec.de>
Signed-off-by: Stefan Riedmueller <s.riedmueller@phytec.de>
---
arch/arm/boards/phytec-som-imx6/board.c | 11 ++++++++++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boards/phytec-som-imx6/board.c b/arch/arm/boards/phytec-som-imx6/board.c
index 4079bc9de1b3..38a2ef641e47 100644
--- a/arch/arm/boards/phytec-som-imx6/board.c
+++ b/arch/arm/boards/phytec-som-imx6/board.c
@@ -99,8 +99,17 @@ static unsigned int get_module_rev(void)
static int ksz8081_phy_fixup(struct phy_device *phydev)
{
+ /*
+ * 0x8100 default
+ * 0x0080 RMII 50 MHz clock mode
+ * 0x0010 LED Mode 1
+ */
phy_write(phydev, 0x1f, 0x8190);
- phy_write(phydev, 0x16, 0x202);
+ /*
+ * 0x0002 Override strap-in for RMII mode
+ * This should be default but after reset we occasionally read 0x0001
+ */
+ phy_write(phydev, 0x16, 0x2);
return 0;
}
--
2.7.4
_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox
next reply other threads:[~2018-12-04 10:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-04 10:43 Stefan Riedmueller [this message]
2018-12-05 7:55 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1543920225-20866-1-git-send-email-s.riedmueller@phytec.de \
--to=s.riedmueller@phytec.de \
--cc=barebox@lists.infradead.org \
--cc=j.remmet@phytec.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox