mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Christian Hemp <c.hemp@phytec.de>
To: barebox@lists.infradead.org
Subject: [PATCH] mci: imx-esdhc-pbl: initialize is_be
Date: Fri, 15 Mar 2019 15:08:52 +0100	[thread overview]
Message-ID: <1552658932-30110-1-git-send-email-c.hemp@phytec.de> (raw)

Initialize is_be, otherwise the value of is_be is undefined.
So it is possible that the i.MX8 will not boot because the bigendian
functions are used.

Signed-off-by: Christian Hemp <c.hemp@phytec.de>
---
 drivers/mci/imx-esdhc-pbl.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/mci/imx-esdhc-pbl.c b/drivers/mci/imx-esdhc-pbl.c
index f77530d..8a03c5f 100644
--- a/drivers/mci/imx-esdhc-pbl.c
+++ b/drivers/mci/imx-esdhc-pbl.c
@@ -366,6 +366,7 @@ int imx6_esdhc_start_image(int instance)
 		return -EINVAL;
 	}
 
+	esdhc.is_be = 0;
 	esdhc.is_mx6 = 1;
 
 	return esdhc_start_image(&esdhc, 0x10000000, 0x10000000, 0);
@@ -398,6 +399,7 @@ int imx8_esdhc_start_image(int instance)
 		return -EINVAL;
 	}
 
+	esdhc.is_be = 0;
 	esdhc.is_mx6 = 1;
 
 	return esdhc_start_image(&esdhc, MX8MQ_DDR_CSD1_BASE_ADDR,
-- 
2.7.4


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

             reply	other threads:[~2019-03-15 14:08 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-15 14:08 Christian Hemp [this message]
2019-03-18  8:45 ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1552658932-30110-1-git-send-email-c.hemp@phytec.de \
    --to=c.hemp@phytec.de \
    --cc=barebox@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox