[PATCH] common: bootchooser: Fix compile warning

[PATCH] common: bootchooser: Fix compile warning

[Teresa Remmet]

Make bootchooser_get_target() static to prevent following warning:

common/bootchooser.c:633:28: warning: no previous prototype for
	 ‘bootchooser_get_target’ [-Wmissing-prototypes]
struct bootchooser_target *bootchooser_get_target(struct bootchooser *bc)

Signed-off-by: Teresa Remmet <t.remmet@phytec.de>
---
 common/bootchooser.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/common/bootchooser.c b/common/bootchooser.c
index c47c734c9c7a..c08db03ebaa1 100644
--- a/common/bootchooser.c
+++ b/common/bootchooser.c
@@ -630,7 +630,7 @@ void bootchooser_info(struct bootchooser *bc)
  *
  * Return: The next target
  */
-struct bootchooser_target *bootchooser_get_target(struct bootchooser *bc)
+static struct bootchooser_target *bootchooser_get_target(struct bootchooser *bc)
 {
 	struct bootchooser_target *target;
 
-- 
2.7.4


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

Re: [PATCH] common: bootchooser: Fix compile warning

[Sascha Hauer]

On Mon, Apr 08, 2019 at 03:25:32PM +0200, Teresa Remmet wrote:
> Make bootchooser_get_target() static to prevent following warning:
> 
> common/bootchooser.c:633:28: warning: no previous prototype for
> 	 ‘bootchooser_get_target’ [-Wmissing-prototypes]
> struct bootchooser_target *bootchooser_get_target(struct bootchooser *bc)
> 
> Signed-off-by: Teresa Remmet <t.remmet@phytec.de>
> ---

Already fixed with 27166fb0b1 ("treewide: Make locally used functions static")

Sascha


>  common/bootchooser.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/common/bootchooser.c b/common/bootchooser.c
> index c47c734c9c7a..c08db03ebaa1 100644
> --- a/common/bootchooser.c
> +++ b/common/bootchooser.c
> @@ -630,7 +630,7 @@ void bootchooser_info(struct bootchooser *bc)
>   *
>   * Return: The next target
>   */
> -struct bootchooser_target *bootchooser_get_target(struct bootchooser *bc)
> +static struct bootchooser_target *bootchooser_get_target(struct bootchooser *bc)
>  {
>  	struct bootchooser_target *target;
>  
> -- 
> 2.7.4
> 
> 
> _______________________________________________
> barebox mailing list
> barebox@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox