mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Christian Eggers <ceggers@arri.de>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: barebox@lists.infradead.org, ceggers@gmx.de
Subject: Re: [PATCH 1/3] watchdog: Select CONFIG_PARAMETER
Date: Wed, 22 Jan 2020 10:39:07 +0100	[thread overview]
Message-ID: <1607136.7P1be9KPAr@n95hx1g2> (raw)
In-Reply-To: <20200122082115.tgwaf72ootkmkf5s@pengutronix.de>

Hi Sascha,

Am Mittwoch, 22. Januar 2020, 09:21:15 CET schrieb Sascha Hauer:
> Hi Christian,
> 
> > diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
> > index 45dd41a2a..34b7fea39 100644
> > --- a/drivers/watchdog/Kconfig
> > +++ b/drivers/watchdog/Kconfig
> > @@ -4,6 +4,7 @@ config WATCHDOG_IMX_RESET_SOURCE
> > 
> >  menuconfig WATCHDOG
> >  
> >  	bool "Watchdog support"
> > 
> > +	select PARAMETER
> 
> I think this goes into the wrong direction. With CONFIG_PARAMETER
> enabled we get support for adjusting device parameters from the shell.
> In environments without shell support parameter support is not needed.
> For example the watchdog C API doesn't need parameter support and is
> still usable.
> 
> The static inline wrappers for dev_add_param_* should return NULL
> instead of returning ERR_PTR(-ENOSYS).

initially I came to the same result. But previous commits to param.h went in 
the opposite direction:

> 03b59bdb64 ("paramter: The dev_add_param_*() return ERR_PTR(), change
> no-ops") to return ERR_PTR(-ENOSYS) instead of NULL
> 
> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

and

> c5d95eb4c7 ("param: make parameter functions more consistent")
>
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

Most of the callers of dev_add_param*()  don't care about the returned param 
pointer at all. Some are checking against PTR_ERR() which would not be hit if 
returning NULL (this is what we want).

A few callers have to changed if a NULL pointer can be returned:
- __nvvar_add()
- state_string_create()  stores the result in state_string::param, but seems 
to be used nowhere
- mci_register() dito for mci::param_probe
- state_uint8_create() dito for state_uint32::param
- state_uint32_create() dito

For me it looks reasonable to return a NULL pointer if CONFIG_PARAMETER is not 
set (as you suggested). Only __nvvar_add() needs slight changes and I would 
remove needless storage of param in structs state_string, mci and 
state_uint32.

Shall I start?

regards
Christian



_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2020-01-22  9:39 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-21 11:44 Christian Eggers
2020-01-21 11:44 ` [PATCH 2/3] usb: otg: " Christian Eggers
2020-01-21 11:44 ` [PATCH 3/3] globalvar: " Christian Eggers
2020-01-22  8:21 ` [PATCH 1/3] watchdog: " Sascha Hauer
2020-01-22  9:39   ` Christian Eggers [this message]
2020-01-22 19:54     ` Sascha Hauer
2020-01-23 11:18       ` Marc Kleine-Budde

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1607136.7P1be9KPAr@n95hx1g2 \
    --to=ceggers@arri.de \
    --cc=barebox@lists.infradead.org \
    --cc=ceggers@gmx.de \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox