mail archive of the barebox mailing list
 help / color / mirror / Atom feed
From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: Sascha Hauer <s.hauer@pengutronix.de>,
	Marco Felsch <m.felsch@pengutronix.de>
Cc: barebox@lists.infradead.org
Subject: Re: [RFC PATCH] ARM: dts: i.MX8MP: remove barebox environment handling
Date: Wed, 11 Feb 2026 10:37:18 +0100	[thread overview]
Message-ID: <1672b0e8-65ac-4f92-afb7-e5c9eb798537@pengutronix.de> (raw)
In-Reply-To: <aYw1kgLBfDsrVpx_@pengutronix.de>

Hi,

On 2/11/26 8:53 AM, Sascha Hauer wrote:
> On Tue, Feb 10, 2026 at 11:13:40PM +0100, Marco Felsch wrote:
>> While specifying the barebox environment within the barebox dts is very
>> helpful for standalone barebox development it's difficult for BSPs which
>> use this development platform and want to use the GPT mechanism.
>> As a result BSPs had to manually delete the nodes via a external
>> provided dts, because we wanted to keep the comfort for the standalone
>> development flow.
>>
>> Lucky commit 86531d4bf7aa ("commands: create createnv command")
>> introduced a convenient helper to create a barebox environemnt on
>> demand exactly for this purpose:
>>
>> | "We want to move away from describing the barebox environment explicitly
>> | in the device tree and instead motivate usage of GPT partitions.."
>>
>> So start with the i.MX8MP-EVK to encourage the use of GPT partitions and
>> to make the BSP integration for these development platforms easier.
> 
> Generally I like this idea, but it breaks the existing users
> environment and doing this sharp cut might be annoying for the phase
> where you switch between different barebox versions which could be quite
> common for development boards.
> 
> Would be great to have a grace period in which we prefer the UUID
> environment over the device tree environment (we might do this already)
> and warn in case we still use the latter. We could stick the warning to
> a device tree property like "warn-deprecated-env" and remove the
> environment once they carry this property for a year or so.
> 
> Just the ideas from the top of my head. Thoughts?

Here's my opinion from a year back:
https://lore.barebox.org/barebox/1ff0f545-effa-4b87-81b7-524919333777@pengutronix.de/

I am interested to hear thoughts on it.
Compared to our suggestion, there will be no eventual removal of the node.

Cheers,
Ahmad

> 
> Sascha
> 
>>
>> Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
>> ---
>>  arch/arm/dts/imx8mp-evk.dts | 43 -------------------------------------
>>  1 file changed, 43 deletions(-)
>>
>> diff --git a/arch/arm/dts/imx8mp-evk.dts b/arch/arm/dts/imx8mp-evk.dts
>> index e6f8c2d1b482..37798fa99efa 100644
>> --- a/arch/arm/dts/imx8mp-evk.dts
>> +++ b/arch/arm/dts/imx8mp-evk.dts
>> @@ -12,19 +12,6 @@
>>  / {
>>  	barebox,deep-probe;
>>  
>> -	chosen {
>> -		environment-sd {
>> -			compatible = "barebox,environment";
>> -			device-path = &env_sd2;
>> -			status = "disabled";
>> -		};
>> -		environment-emmc {
>> -			compatible = "barebox,environment";
>> -			device-path = &env_sd3;
>> -			status = "disabled";
>> -		};
>> -	};
>> -
>>  	gpio-leds {
>>  		status {
>>  			barebox,default-trigger = "heartbeat";
>> @@ -78,33 +65,3 @@ &usb_dwc3_0 {
>>  	usb-role-switch;
>>  	status = "okay";
>>  };
>> -
>> -&usdhc2 {
>> -	#address-cells = <1>;
>> -	#size-cells = <1>;
>> -
>> -	partition@0 {
>> -		label = "barebox";
>> -		reg = <0x0 0xe0000>;
>> -	};
>> -
>> -	env_sd2: partition@e0000 {
>> -		label = "barebox-environment";
>> -		reg = <0xe0000 0x20000>;
>> -	};
>> -};
>> -
>> -&usdhc3 {
>> -	#address-cells = <1>;
>> -	#size-cells = <1>;
>> -
>> -	partition@0 {
>> -		label = "barebox";
>> -		reg = <0x0 0xe0000>;
>> -	};
>> -
>> -	env_sd3: partition@e0000 {
>> -		label = "barebox-environment";
>> -		reg = <0xe0000 0x20000>;
>> -	};
>> -};
>> -- 
>> 2.47.3
>>
>>
>>
> 

-- 
Pengutronix e.K.                  |                             |
Steuerwalder Str. 21              | http://www.pengutronix.de/  |
31137 Hildesheim, Germany         | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686  | Fax:   +49-5121-206917-5555 |




  reply	other threads:[~2026-02-11  9:37 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-10 22:13 Marco Felsch
2026-02-11  7:53 ` Sascha Hauer
2026-02-11  9:37   ` Ahmad Fatoum [this message]
2026-02-11  9:58     ` Sascha Hauer
2026-02-11 10:14     ` Marco Felsch
2026-02-11 12:53       ` Sascha Hauer
2026-02-11 12:56         ` Ahmad Fatoum

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1672b0e8-65ac-4f92-afb7-e5c9eb798537@pengutronix.de \
    --to=a.fatoum@pengutronix.de \
    --cc=barebox@lists.infradead.org \
    --cc=m.felsch@pengutronix.de \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox