From: Sascha Hauer <s.hauer@pengutronix.de>
To: barebox@lists.infradead.org, Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: Re: [PATCH master v2 1/2] hab: habv4: use explicitly unsigned types for pointers into SRAM
Date: Thu, 11 Jan 2024 16:15:46 +0100 [thread overview]
Message-ID: <170498614609.860897.7644310042114187767.b4-ty@pengutronix.de> (raw)
In-Reply-To: <20240111130015.1784217-1-a.fatoum@pengutronix.de>
On Thu, 11 Jan 2024 14:00:14 +0100, Ahmad Fatoum wrote:
> char is generally unsigned on ARM, but we shouldn't rely on that. HAB
> code does though and compare a char against 0xdb, which would never
> succeed if chars were signed. Switch to an explicitly unsigned type to
> fix this.
>
>
Applied, thanks!
[1/2] hab: habv4: use explicitly unsigned types for pointers into SRAM
https://git.pengutronix.de/cgit/barebox/commit/?id=225368d37470 (link may not be stable)
[2/2] hab: habv4: warn if more than 10 HAB events are found
https://git.pengutronix.de/cgit/barebox/commit/?id=f90d6e70bce6 (link may not be stable)
Best regards,
--
Sascha Hauer <s.hauer@pengutronix.de>
prev parent reply other threads:[~2024-01-11 15:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-11 13:00 Ahmad Fatoum
2024-01-11 13:00 ` [PATCH master v2 2/2] hab: habv4: warn if more than 10 HAB events are found Ahmad Fatoum
2024-01-11 15:15 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=170498614609.860897.7644310042114187767.b4-ty@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox