[PATCH] usb: core: replace calls to strerror with %pe format specifier

[PATCH] usb: core: replace calls to strerror with %pe format specifier

[Ahmad Fatoum]

printf(), and by extension dev_err(), already has built-in support for
formatting error codes, so make use of that instead of manual use of
strerror().

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 drivers/usb/core/usb.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/usb/core/usb.c b/drivers/usb/core/usb.c
index 62d9f11146a9..614527fecbf3 100644
--- a/drivers/usb/core/usb.c
+++ b/drivers/usb/core/usb.c
@@ -477,8 +477,8 @@ int usb_new_device(struct usb_device *dev)
 	/* we set the default configuration here */
 	err = usb_set_configuration(dev, dev->config.desc.bConfigurationValue);
 	if (err) {
-		dev_err(&dev->dev, "Setting default configuration failed with: %s\n" \
-			"len %d, status %lX\n", strerror(-err),
+		dev_err(&dev->dev, "Setting default configuration failed with: %pe\n" \
+			"len %d, status %lX\n", ERR_PTR(err),
 		       dev->act_len, dev->status);
 		goto err_out;
 	}
@@ -502,7 +502,7 @@ int usb_new_device(struct usb_device *dev)
 
 	err = register_device(&dev->dev);
 	if (err) {
-		dev_err(&dev->dev, "Failed to register device: %s\n", strerror(-err));
+		dev_err(&dev->dev, "Failed to register device: %pe\n", ERR_PTR(err));
 		goto err_out;
 	}
 
-- 
2.39.2

Re: [PATCH] usb: core: replace calls to strerror with %pe format specifier

[Sascha Hauer]

On Mon, 19 Feb 2024 18:21:08 +0100, Ahmad Fatoum wrote:
> printf(), and by extension dev_err(), already has built-in support for
> formatting error codes, so make use of that instead of manual use of
> strerror().
> 
> 

Applied, thanks!

[1/1] usb: core: replace calls to strerror with %pe format specifier
      https://git.pengutronix.de/cgit/barebox/commit/?id=ecab0d0bc4c9 (link may not be stable)

Best regards,
-- 
Sascha Hauer <s.hauer@pengutronix.de>