From: Sascha Hauer <s.hauer@pengutronix.de>
To: barebox@lists.infradead.org, Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: Re: [PATCH] treewide: use dev_err_probe instead of comparisons against EPROBE_DEFER
Date: Tue, 20 Feb 2024 08:27:01 +0100 [thread overview]
Message-ID: <170841402179.588781.7122911611501895669.b4-ty@pengutronix.de> (raw)
In-Reply-To: <20240219172659.3796647-1-a.fatoum@pengutronix.de>
On Mon, 19 Feb 2024 18:26:59 +0100, Ahmad Fatoum wrote:
> Drivers should not need to compare an error value against EPROBE_DEFER.
> We have a number of drivers doing that though to decide whether to print
> an error or not. This error message will be lost if the probe is
> deferred, so use dev_err_probe to store the error in that case.
>
> While at it, we shorten the error messages a bit. dev_err_probe will
> already print the string 'error' before the error code string.
>
> [...]
Applied, thanks!
[1/1] treewide: use dev_err_probe instead of comparisons against EPROBE_DEFER
https://git.pengutronix.de/cgit/barebox/commit/?id=b305ee5e0439 (link may not be stable)
Best regards,
--
Sascha Hauer <s.hauer@pengutronix.de>
next prev parent reply other threads:[~2024-02-20 7:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-19 17:26 Ahmad Fatoum
2024-02-20 7:27 ` Sascha Hauer [this message]
2024-02-20 7:28 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=170841402179.588781.7122911611501895669.b4-ty@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox