mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH master] ARM: i.MX8MP: dts: remove power domains referenced by media_blk_ctrl
@ 2024-02-20 17:25 Ahmad Fatoum
  2024-02-23  7:32 ` Sascha Hauer
  0 siblings, 1 reply; 2+ messages in thread
From: Ahmad Fatoum @ 2024-02-20 17:25 UTC (permalink / raw)
  To: barebox; +Cc: ukl, Ahmad Fatoum

The media_blk_ctrl is hardcoded in the DT to reference a number of power
domains that we delete. The media_blk_ctrl itself is still usable
without them (e.g. LVDS doesn't require ISP), but the probe in Linux
would fail, because the power domain can't be attached.

This has already been fixed once in commit 5600290f4bf1
("/arch/arm/dts: imx8mp: Do not mask out mediamix power domain"), but
got reintroduced recently.

As the upstream DT has no ISP node and we already disable the MIPI DSI
node, let's just leave the power domains untouched and see how that
fares.

Fixes: aaea50bbcde2 ("soc: imx: featctrl: finalize support for i.MX8MP")
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 arch/arm/dts/imx8mp.dtsi | 12 ------------
 1 file changed, 12 deletions(-)

diff --git a/arch/arm/dts/imx8mp.dtsi b/arch/arm/dts/imx8mp.dtsi
index 9d87ddaea836..6c84cfb21101 100644
--- a/arch/arm/dts/imx8mp.dtsi
+++ b/arch/arm/dts/imx8mp.dtsi
@@ -40,10 +40,6 @@ feat: &ocotp {
 	barebox,feature-controller;
 };
 
-&pgc_mipi_phy1 {
-	barebox,feature-gates = <&feat IMX8M_FEAT_MIPI_DSI>;
-};
-
 &pgc_gpu2d {
 	barebox,feature-gates = <&feat IMX8M_FEAT_GPU>;
 };
@@ -56,10 +52,6 @@ &pgc_gpumix {
 	barebox,feature-gates = <&feat IMX8M_FEAT_GPU>;
 };
 
-&pgc_mipi_phy2 {
-	barebox,feature-gates = <&feat IMX8M_FEAT_MIPI_DSI>;
-};
-
 &mipi_dsi {
 	barebox,feature-gates = <&feat IMX8M_FEAT_MIPI_DSI>;
 };
@@ -68,10 +60,6 @@ &lcdif1 {
 	barebox,feature-gates = <&feat IMX8M_FEAT_MIPI_DSI>;
 };
 
-&pgc_ispdwp {
-	barebox,feature-gates = <&feat IMX8M_FEAT_ISP>;
-};
-
 &gpu3d {
 	barebox,feature-gates = <&feat IMX8M_FEAT_GPU>;
 };
-- 
2.39.2




^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH master] ARM: i.MX8MP: dts: remove power domains referenced by media_blk_ctrl
  2024-02-20 17:25 [PATCH master] ARM: i.MX8MP: dts: remove power domains referenced by media_blk_ctrl Ahmad Fatoum
@ 2024-02-23  7:32 ` Sascha Hauer
  0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2024-02-23  7:32 UTC (permalink / raw)
  To: barebox, Ahmad Fatoum; +Cc: ukl


On Tue, 20 Feb 2024 18:25:27 +0100, Ahmad Fatoum wrote:
> The media_blk_ctrl is hardcoded in the DT to reference a number of power
> domains that we delete. The media_blk_ctrl itself is still usable
> without them (e.g. LVDS doesn't require ISP), but the probe in Linux
> would fail, because the power domain can't be attached.
> 
> This has already been fixed once in commit 5600290f4bf1
> ("/arch/arm/dts: imx8mp: Do not mask out mediamix power domain"), but
> got reintroduced recently.
> 
> [...]

Applied, thanks!

[1/1] ARM: i.MX8MP: dts: remove power domains referenced by media_blk_ctrl
      https://git.pengutronix.de/cgit/barebox/commit/?id=02f8945abcb0 (link may not be stable)

Best regards,
-- 
Sascha Hauer <s.hauer@pengutronix.de>




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-02-23  7:37 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-20 17:25 [PATCH master] ARM: i.MX8MP: dts: remove power domains referenced by media_blk_ctrl Ahmad Fatoum
2024-02-23  7:32 ` Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox