* [PATCH] mci: mci-core: make devinfo hex values obvious
@ 2024-03-26 6:45 Rouven Czerwinski
2024-03-26 10:20 ` Sascha Hauer
0 siblings, 1 reply; 2+ messages in thread
From: Rouven Czerwinski @ 2024-03-26 6:45 UTC (permalink / raw)
To: barebox; +Cc: Rouven Czerwinski
The Manufacturer and OEM/Application ID are printed as hex values, but
don't have a leading zero to designate them as hex to a human reader.
Add the leading 0x to make it obvious that these are hex values.
Signed-off-by: Rouven Czerwinski <r.czerwinski@pengutronix.de>
---
drivers/mci/mci-core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mci/mci-core.c b/drivers/mci/mci-core.c
index 414bcf6f06..9d6d01f8bc 100644
--- a/drivers/mci/mci-core.c
+++ b/drivers/mci/mci-core.c
@@ -2058,8 +2058,8 @@ static void mci_info(struct device *dev)
mci->csd[2], mci->csd[3]);
printf(" Max. transfer speed: %u Hz\n", mci->tran_speed);
mci_print_caps(mci->card_caps);
- printf(" Manufacturer ID: %02X\n", extract_mid(mci));
- printf(" OEM/Application ID: %04X\n", extract_oid(mci));
+ printf(" Manufacturer ID: 0x%02X\n", extract_mid(mci));
+ printf(" OEM/Application ID: 0x%04X\n", extract_oid(mci));
printf(" Product name: '%c%c%c%c%c'\n", mci->cid[0] & 0xff,
(mci->cid[1] >> 24), (mci->cid[1] >> 16) & 0xff,
(mci->cid[1] >> 8) & 0xff, mci->cid[1] & 0xff);
--
2.44.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] mci: mci-core: make devinfo hex values obvious
2024-03-26 6:45 [PATCH] mci: mci-core: make devinfo hex values obvious Rouven Czerwinski
@ 2024-03-26 10:20 ` Sascha Hauer
0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2024-03-26 10:20 UTC (permalink / raw)
To: barebox, Rouven Czerwinski
On Tue, 26 Mar 2024 07:45:51 +0100, Rouven Czerwinski wrote:
> The Manufacturer and OEM/Application ID are printed as hex values, but
> don't have a leading zero to designate them as hex to a human reader.
> Add the leading 0x to make it obvious that these are hex values.
>
>
Applied, thanks!
[1/1] mci: mci-core: make devinfo hex values obvious
https://git.pengutronix.de/cgit/barebox/commit/?id=6d86a97266d1 (link may not be stable)
Best regards,
--
Sascha Hauer <s.hauer@pengutronix.de>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-03-26 10:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-26 6:45 [PATCH] mci: mci-core: make devinfo hex values obvious Rouven Czerwinski
2024-03-26 10:20 ` Sascha Hauer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox