[PATCH] of: do not acccess 'prop->value' directly

[PATCH] of: do not acccess 'prop->value' directly

[Enrico Scholz]

From: Enrico Scholz <enrico.scholz@sigma-chemnitz.de>

Use of_property_get_value() accessor.  Else, wrong results are
returned when working with fit images.

Signed-off-by: Enrico Scholz <enrico.scholz@sigma-chemnitz.de>
---
 drivers/of/base.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/of/base.c b/drivers/of/base.c
index b22959dabebf..9bd0cdaac2ad 100644
--- a/drivers/of/base.c
+++ b/drivers/of/base.c
@@ -853,7 +853,7 @@ int of_property_count_elems_of_size(const struct device_node *np,
 
 	if (!prop)
 		return -EINVAL;
-	if (!prop->value)
+	if (!of_property_get_value(prop))
 		return -ENODATA;
 
 	if (prop->length % elem_size != 0) {
@@ -2009,9 +2009,9 @@ int of_property_read_string_helper(const struct device_node *np,
 
 	if (!prop)
 		return -EINVAL;
-	if (!prop->value)
+	p = of_property_get_value(prop);
+	if (!p)
 		return -ENODATA;
-	p = prop->value;
 	end = p + prop->length;
 
 	for (i = 0; p < end && (!out_strs || i < skip + sz); i++, p += l) {
-- 
2.44.0

Re: [PATCH] of: do not acccess 'prop->value' directly

[Sascha Hauer]

On Fri, 12 Apr 2024 18:29:25 +0200, Enrico Scholz wrote:
> Use of_property_get_value() accessor.  Else, wrong results are
> returned when working with fit images.
> 
> 

Applied, thanks!

[1/1] of: do not acccess 'prop->value' directly
      https://git.pengutronix.de/cgit/barebox/commit/?id=7b7ab4a37d25 (link may not be stable)

Best regards,
-- 
Sascha Hauer <s.hauer@pengutronix.de>