mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH] ARM: i.MX8MP: fix compatible string for koenigbauer,alphajet board
@ 2024-04-30 10:23 Roland Hieber
  2024-04-30 12:05 ` Ahmad Fatoum
  2024-05-03  7:22 ` Sascha Hauer
  0 siblings, 2 replies; 3+ messages in thread
From: Roland Hieber @ 2024-04-30 10:23 UTC (permalink / raw)
  To: barebox; +Cc: Roland Hieber, Ahmad Fatoum

During the review of the initial board support patch, the SoM compatible
was changed (and unified) to "congatec,qmx8p" from several different
incompatible variants. However, the compatible in the alphajet device
tree contained a different typo and was overlooked, which had the effect
that the barebox_update handler and the Ethernet fixups were not
registered on the alphajet board.

Fixes: 34f14b1519715d47d879 (2024-03-11, "ARM: i.MX8MP: add König+Bauer AlphaJet board")
Rubberducked-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
Signed-off-by: Roland Hieber <rhi@pengutronix.de>
---
 arch/arm/dts/imx8mp-koenigbauer-alphajet.kernel.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/dts/imx8mp-koenigbauer-alphajet.kernel.dts b/arch/arm/dts/imx8mp-koenigbauer-alphajet.kernel.dts
index 3f958ddf78e8..198fe1379a05 100644
--- a/arch/arm/dts/imx8mp-koenigbauer-alphajet.kernel.dts
+++ b/arch/arm/dts/imx8mp-koenigbauer-alphajet.kernel.dts
@@ -7,7 +7,7 @@
 
 / {
 	model = "Koenig+Bauer Alphajet";
-	compatible = "koenigbauer,alphajet", "congatec,qmxp8p", "fsl,imx8mp";
+	compatible = "koenigbauer,alphajet", "congatec,qmx8p", "fsl,imx8mp";
 
 	display {
 		compatible = "innolux,g101ice-l01";
-- 
2.39.2




^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ARM: i.MX8MP: fix compatible string for koenigbauer,alphajet board
  2024-04-30 10:23 [PATCH] ARM: i.MX8MP: fix compatible string for koenigbauer,alphajet board Roland Hieber
@ 2024-04-30 12:05 ` Ahmad Fatoum
  2024-05-03  7:22 ` Sascha Hauer
  1 sibling, 0 replies; 3+ messages in thread
From: Ahmad Fatoum @ 2024-04-30 12:05 UTC (permalink / raw)
  To: Roland Hieber, barebox

On 30.04.24 12:23, Roland Hieber wrote:
> During the review of the initial board support patch, the SoM compatible
> was changed (and unified) to "congatec,qmx8p" from several different
> incompatible variants. However, the compatible in the alphajet device
> tree contained a different typo and was overlooked, which had the effect
> that the barebox_update handler and the Ethernet fixups were not
> registered on the alphajet board.
> 
> Fixes: 34f14b1519715d47d879 (2024-03-11, "ARM: i.MX8MP: add König+Bauer AlphaJet board")
> Rubberducked-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> Signed-off-by: Roland Hieber <rhi@pengutronix.de>
> ---
>  arch/arm/dts/imx8mp-koenigbauer-alphajet.kernel.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/dts/imx8mp-koenigbauer-alphajet.kernel.dts b/arch/arm/dts/imx8mp-koenigbauer-alphajet.kernel.dts
> index 3f958ddf78e8..198fe1379a05 100644
> --- a/arch/arm/dts/imx8mp-koenigbauer-alphajet.kernel.dts
> +++ b/arch/arm/dts/imx8mp-koenigbauer-alphajet.kernel.dts
> @@ -7,7 +7,7 @@
>  
>  / {
>  	model = "Koenig+Bauer Alphajet";
> -	compatible = "koenigbauer,alphajet", "congatec,qmxp8p", "fsl,imx8mp";
> +	compatible = "koenigbauer,alphajet", "congatec,qmx8p", "fsl,imx8mp";

Reviewed-by: Ahmad Fatoum <a.fatoum@pengutronix.de>

>  
>  	display {
>  		compatible = "innolux,g101ice-l01";

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |




^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ARM: i.MX8MP: fix compatible string for koenigbauer,alphajet board
  2024-04-30 10:23 [PATCH] ARM: i.MX8MP: fix compatible string for koenigbauer,alphajet board Roland Hieber
  2024-04-30 12:05 ` Ahmad Fatoum
@ 2024-05-03  7:22 ` Sascha Hauer
  1 sibling, 0 replies; 3+ messages in thread
From: Sascha Hauer @ 2024-05-03  7:22 UTC (permalink / raw)
  To: barebox, Roland Hieber; +Cc: Ahmad Fatoum


On Tue, 30 Apr 2024 12:23:57 +0200, Roland Hieber wrote:
> During the review of the initial board support patch, the SoM compatible
> was changed (and unified) to "congatec,qmx8p" from several different
> incompatible variants. However, the compatible in the alphajet device
> tree contained a different typo and was overlooked, which had the effect
> that the barebox_update handler and the Ethernet fixups were not
> registered on the alphajet board.
> 
> [...]

Applied, thanks!

[1/1] ARM: i.MX8MP: fix compatible string for koenigbauer,alphajet board
      https://git.pengutronix.de/cgit/barebox/commit/?id=f18bb339857d (link may not be stable)

Best regards,
-- 
Sascha Hauer <s.hauer@pengutronix.de>




^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-05-03  7:22 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-30 10:23 [PATCH] ARM: i.MX8MP: fix compatible string for koenigbauer,alphajet board Roland Hieber
2024-04-30 12:05 ` Ahmad Fatoum
2024-05-03  7:22 ` Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox