[PATCH] common: hide DEFAULT_COMPRESSION menu

[PATCH] common: hide DEFAULT_COMPRESSION menu

[Ahmad Fatoum]

CONFIG_DEFAULT_COMPRESSION_* refers to the compression done for
in-barebox binaries and is not useful when barebox proper as a whole is
compressed as in that case, we would have compression applied twice.

For this reason, DEFAULT_COMPRESSION_NONE is the only possible choice in
a PBL-enabled build. Having the choice with only one option is confusing
though, so let's hide the prompt.

Preferably, we'd omit these options in PBL builds completely, but this
seems not easily possible.

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 common/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/common/Kconfig b/common/Kconfig
index 67cbbf5197da..366521dadfe1 100644
--- a/common/Kconfig
+++ b/common/Kconfig
@@ -921,8 +921,8 @@ config DEFAULT_ENVIRONMENT
 	  CONFIG_ENV_HANDLING is not enabled.
 
 choice
-	prompt "default compression for in-barebox binaries"
-	default DEFAULT_COMPRESSION_NONE if PBL_IMAGE
+	prompt "default compression for in-barebox binaries" if PBL_IMAGE
+	default DEFAULT_COMPRESSION_NONE
 	default DEFAULT_COMPRESSION_LZO if LZO_DECOMPRESS
 	default DEFAULT_COMPRESSION_XZ if XZ_DECOMPRESS
 	default DEFAULT_COMPRESSION_GZIP if ZLIB
-- 
2.39.2

Re: [PATCH] common: hide DEFAULT_COMPRESSION menu

[Sascha Hauer]

On Fri, 17 May 2024 08:21:51 +0200, Ahmad Fatoum wrote:
> CONFIG_DEFAULT_COMPRESSION_* refers to the compression done for
> in-barebox binaries and is not useful when barebox proper as a whole is
> compressed as in that case, we would have compression applied twice.
> 
> For this reason, DEFAULT_COMPRESSION_NONE is the only possible choice in
> a PBL-enabled build. Having the choice with only one option is confusing
> though, so let's hide the prompt.
> 
> [...]

Applied, thanks!

[1/1] common: hide DEFAULT_COMPRESSION menu
      https://git.pengutronix.de/cgit/barebox/commit/?id=f661c703ff46 (link may not be stable)

Best regards,
-- 
Sascha Hauer <s.hauer@pengutronix.de>