From: Sascha Hauer <s.hauer@pengutronix.de>
To: barebox@lists.infradead.org, Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: Re: [PATCH master] bitops: change test_bit return type from int to bool
Date: Mon, 01 Jul 2024 11:34:17 +0200 [thread overview]
Message-ID: <171982645707.2314789.10438292536647188639.b4-ty@pengutronix.de> (raw)
In-Reply-To: <20240701073509.176191-1-a.fatoum@pengutronix.de>
On Mon, 01 Jul 2024 09:35:09 +0200, Ahmad Fatoum wrote:
> test_bit currently returns some positive integer on success and don't
> enforce the return values to be either false or true.
>
> This can lead to problems if the return value is not used for
> truthiness, but in arithmetic.
>
> This seems to be the case only in KASAN code, where it's used to count
> errors. Change the return type to fix this.
>
> [...]
Applied, thanks!
[1/1] bitops: change test_bit return type from int to bool
https://git.pengutronix.de/cgit/barebox/commit/?id=4e47b8b03bce (link may not be stable)
Best regards,
--
Sascha Hauer <s.hauer@pengutronix.de>
prev parent reply other threads:[~2024-07-01 9:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-01 7:35 Ahmad Fatoum
2024-07-01 9:34 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=171982645707.2314789.10438292536647188639.b4-ty@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox