[PATCH] mci: core: drop unused parameter members from struct mci

[PATCH] mci: core: drop unused parameter members from struct mci

[Ahmad Fatoum]

We actually never check the device parameter points again in the MCI
core, so we don' need to keep them in struct mci.

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 drivers/mci/mci-core.c | 14 ++++++--------
 include/mci.h          |  2 --
 2 files changed, 6 insertions(+), 10 deletions(-)

diff --git a/drivers/mci/mci-core.c b/drivers/mci/mci-core.c
index b91d51b43a0b..f6f8a6adabb9 100644
--- a/drivers/mci/mci-core.c
+++ b/drivers/mci/mci-core.c
@@ -2417,15 +2417,13 @@ static int mci_card_probe(struct mci *mci)
 	}
 
 	if (has_bootpart) {
-		mci->param_boot =
-			dev_add_param_enum(&mci->dev, "boot", mci_set_boot,
-					   NULL, &mci->bootpart, mci_boot_names,
-					   ARRAY_SIZE(mci_boot_names), mci);
+		dev_add_param_enum(&mci->dev, "boot", mci_set_boot,
+				   NULL, &mci->bootpart, mci_boot_names,
+				   ARRAY_SIZE(mci_boot_names), mci);
 
-		mci->param_boot_ack =
-			dev_add_param_bool(&mci->dev, "boot_ack",
-					   mci_set_boot_ack, NULL,
-					   &mci->boot_ack_enable, mci);
+		dev_add_param_bool(&mci->dev, "boot_ack",
+				   mci_set_boot_ack, NULL,
+				   &mci->boot_ack_enable, mci);
 
 		ret = mci_get_partition_setting_completed(mci);
 		if (ret < 0)
diff --git a/include/mci.h b/include/mci.h
index 70529d065087..773aed896c96 100644
--- a/include/mci.h
+++ b/include/mci.h
@@ -580,8 +580,6 @@ struct mci {
 	int dsr_imp;		/**< DSR implementation state from CSD */
 	u8 *ext_csd;
 	int probe;
-	struct param_d *param_boot;
-	struct param_d *param_boot_ack;
 	int bootpart;
 	int boot_ack_enable;
 
-- 
2.39.2

Re: [PATCH] mci: core: drop unused parameter members from struct mci

[Sascha Hauer]

On Mon, 01 Jul 2024 09:07:24 +0200, Ahmad Fatoum wrote:
> We actually never check the device parameter points again in the MCI
> core, so we don' need to keep them in struct mci.
> 
> 

Applied, thanks!

[1/1] mci: core: drop unused parameter members from struct mci
      https://git.pengutronix.de/cgit/barebox/commit/?id=88d699393148 (link may not be stable)

Best regards,
-- 
Sascha Hauer <s.hauer@pengutronix.de>