mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH 1/2] ci: bump action versions
@ 2024-07-17  6:19 Ahmad Fatoum
  2024-07-17  6:19 ` [PATCH 2/2] ci: labgrid: use different names per Test Results entry Ahmad Fatoum
  2024-07-19  6:38 ` [PATCH 1/2] ci: bump action versions Sascha Hauer
  0 siblings, 2 replies; 3+ messages in thread
From: Ahmad Fatoum @ 2024-07-17  6:19 UTC (permalink / raw)
  To: barebox; +Cc: Ahmad Fatoum

Github Actions run log warnings about some of our actions being
deprecated, because they use outdated node.js versions.

For actions/checkout we just need to bump the version.
actions/upload-artifact@v4 now refuses identically named artifacts,
so we fix this by factoring in the name of the defconfig.

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 .github/workflows/build-defconfigs.yml    | 2 +-
 .github/workflows/container.yml           | 2 +-
 .github/workflows/test-labgrid-pytest.yml | 6 +++---
 3 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/.github/workflows/build-defconfigs.yml b/.github/workflows/build-defconfigs.yml
index 6690b9db25b8..46f59fd118c1 100644
--- a/.github/workflows/build-defconfigs.yml
+++ b/.github/workflows/build-defconfigs.yml
@@ -31,7 +31,7 @@ jobs:
 
     steps:
     - name: Checkout code
-      uses: actions/checkout@v3
+      uses: actions/checkout@v4
 
     - name: Build
       run: |
diff --git a/.github/workflows/container.yml b/.github/workflows/container.yml
index 7a9b2fe74d57..9bb23a5836ac 100644
--- a/.github/workflows/container.yml
+++ b/.github/workflows/container.yml
@@ -13,7 +13,7 @@ jobs:
   build:
     runs-on: ubuntu-latest
     steps:
-    - uses: actions/checkout@v3
+    - uses: actions/checkout@v4
     - id: build-image
       uses: redhat-actions/buildah-build@v2
       with:
diff --git a/.github/workflows/test-labgrid-pytest.yml b/.github/workflows/test-labgrid-pytest.yml
index 21d189880941..42a796a157e1 100644
--- a/.github/workflows/test-labgrid-pytest.yml
+++ b/.github/workflows/test-labgrid-pytest.yml
@@ -49,7 +49,7 @@ jobs:
 
     steps:
     - name: Checkout code
-      uses: actions/checkout@v3
+      uses: actions/checkout@v4
 
     - name: Build
       run: |
@@ -83,9 +83,9 @@ jobs:
         files: ./*.tests.xml
 
     - name: Publish Labgrid Log Results
-      uses: actions/upload-artifact@v3
+      uses: actions/upload-artifact@v4
       if: always()
       with:
-        name: Console Logs
+        name: console-log-${{matrix.defconfig}}
         path: log/
         if-no-files-found: error
-- 
2.39.2




^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH 2/2] ci: labgrid: use different names per Test Results entry
  2024-07-17  6:19 [PATCH 1/2] ci: bump action versions Ahmad Fatoum
@ 2024-07-17  6:19 ` Ahmad Fatoum
  2024-07-19  6:38 ` [PATCH 1/2] ci: bump action versions Sascha Hauer
  1 sibling, 0 replies; 3+ messages in thread
From: Ahmad Fatoum @ 2024-07-17  6:19 UTC (permalink / raw)
  To: barebox; +Cc: Ahmad Fatoum

We run the EnricoMi/publish-unit-test-result-action@v2 for each job and
they all have the same name leading to the Jobs sidebar on the Github
Actions Tab to list many duplicated "Test Results" entries[1].

This can be avoided by using a unique check_name for each job and this
leads to a cleaner result as seen in [2].

[1]: https://github.com/a3f/barebox/actions/runs/9962639998
[2]: https://github.com/a3f/barebox/actions/runs/9964226753

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 .github/workflows/test-labgrid-pytest.yml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/.github/workflows/test-labgrid-pytest.yml b/.github/workflows/test-labgrid-pytest.yml
index 42a796a157e1..2e038e371f1e 100644
--- a/.github/workflows/test-labgrid-pytest.yml
+++ b/.github/workflows/test-labgrid-pytest.yml
@@ -80,6 +80,7 @@ jobs:
       uses: EnricoMi/publish-unit-test-result-action@v2
       if: always()
       with:
+        check_name: "Test Results (${{matrix.defconfig}})"
         files: ./*.tests.xml
 
     - name: Publish Labgrid Log Results
-- 
2.39.2




^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/2] ci: bump action versions
  2024-07-17  6:19 [PATCH 1/2] ci: bump action versions Ahmad Fatoum
  2024-07-17  6:19 ` [PATCH 2/2] ci: labgrid: use different names per Test Results entry Ahmad Fatoum
@ 2024-07-19  6:38 ` Sascha Hauer
  1 sibling, 0 replies; 3+ messages in thread
From: Sascha Hauer @ 2024-07-19  6:38 UTC (permalink / raw)
  To: barebox, Ahmad Fatoum


On Wed, 17 Jul 2024 08:19:40 +0200, Ahmad Fatoum wrote:
> Github Actions run log warnings about some of our actions being
> deprecated, because they use outdated node.js versions.
> 
> For actions/checkout we just need to bump the version.
> actions/upload-artifact@v4 now refuses identically named artifacts,
> so we fix this by factoring in the name of the defconfig.
> 
> [...]

Applied, thanks!

[1/2] ci: bump action versions
      https://git.pengutronix.de/cgit/barebox/commit/?id=fc5f4bf42d5c (link may not be stable)
[2/2] ci: labgrid: use different names per Test Results entry
      https://git.pengutronix.de/cgit/barebox/commit/?id=8b3cb3dc8765 (link may not be stable)

Best regards,
-- 
Sascha Hauer <s.hauer@pengutronix.de>




^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-07-19  6:39 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-07-17  6:19 [PATCH 1/2] ci: bump action versions Ahmad Fatoum
2024-07-17  6:19 ` [PATCH 2/2] ci: labgrid: use different names per Test Results entry Ahmad Fatoum
2024-07-19  6:38 ` [PATCH 1/2] ci: bump action versions Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox