From: Sascha Hauer <s.hauer@pengutronix.de>
To: barebox@lists.infradead.org, Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: Re: [PATCH v2 1/2] xfuncs: return NULL from xstrdup_wchar(NULL)
Date: Fri, 19 Jul 2024 08:40:49 +0200 [thread overview]
Message-ID: <172137124927.581111.10897382337951133822.b4-ty@pengutronix.de> (raw)
In-Reply-To: <20240717072843.2828788-1-a.fatoum@pengutronix.de>
On Wed, 17 Jul 2024 09:28:42 +0200, Ahmad Fatoum wrote:
> strdup_wchar, strdup_char_to_wchar and xstrdup_wchar_to_char all return
> NULL when passed a NULL pointer. It's thus misleading for the xfunc
> version of them to trigger an enomem_panic in that case.
>
> Fix this by passing along the NULL pointer unchanged.
> xstrdup() already behaves exactly this way.
>
> [...]
Applied, thanks!
[1/2] xfuncs: return NULL from xstrdup_wchar(NULL)
https://git.pengutronix.de/cgit/barebox/commit/?id=4cb8c6cd241b (link may not be stable)
[2/2] include: xfuncs: employ compiler attributes to aid GCC warnings
https://git.pengutronix.de/cgit/barebox/commit/?id=86f784ae4e68 (link may not be stable)
Best regards,
--
Sascha Hauer <s.hauer@pengutronix.de>
prev parent reply other threads:[~2024-07-19 6:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-17 7:28 Ahmad Fatoum
2024-07-17 7:28 ` [PATCH v2 2/2] include: xfuncs: employ compiler attributes to aid GCC warnings Ahmad Fatoum
2024-07-19 6:40 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=172137124927.581111.10897382337951133822.b4-ty@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox