mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH] ARM: i.MX8M: bootrom-cmd: include missing linux/kernel.h header
@ 2024-07-22 16:26 Ahmad Fatoum
  2024-07-24  8:06 ` Sascha Hauer
  0 siblings, 1 reply; 2+ messages in thread
From: Ahmad Fatoum @ 2024-07-22 16:26 UTC (permalink / raw)
  To: barebox; +Cc: Ahmad Fatoum

The header is needed for ARRAY_SIZE and kstrtoul definition, but was
only included so far indirectly via <command.h> including <linux/list.h>
itself including <linux/kernel.h>.

In preparation for removing the <linux/kernel.h> include from
<linux/list.h>, include the header directly to avoid build errors.

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
Hello Sascha,

please order before
"include: list: replace full kernel.h inclusion with smaller container_of.h"
---
 arch/arm/mach-imx/bootrom-cmd.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/mach-imx/bootrom-cmd.c b/arch/arm/mach-imx/bootrom-cmd.c
index 08e393b01ae1..76455db301fe 100644
--- a/arch/arm/mach-imx/bootrom-cmd.c
+++ b/arch/arm/mach-imx/bootrom-cmd.c
@@ -8,6 +8,7 @@
 #include <linux/bitfield.h>
 #include <mach/imx/imx8m-regs.h>
 #include <mach/imx/romapi.h>
+#include <linux/kernel.h>
 
 /* i.MX7 and later ID field is swapped compared to i.MX6 */
 #define ROM_EVENT_FORMAT_V0_RES	GENMASK(31, 24)
-- 
2.39.2




^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] ARM: i.MX8M: bootrom-cmd: include missing linux/kernel.h header
  2024-07-22 16:26 [PATCH] ARM: i.MX8M: bootrom-cmd: include missing linux/kernel.h header Ahmad Fatoum
@ 2024-07-24  8:06 ` Sascha Hauer
  0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2024-07-24  8:06 UTC (permalink / raw)
  To: barebox, Ahmad Fatoum


On Mon, 22 Jul 2024 18:26:29 +0200, Ahmad Fatoum wrote:
> The header is needed for ARRAY_SIZE and kstrtoul definition, but was
> only included so far indirectly via <command.h> including <linux/list.h>
> itself including <linux/kernel.h>.
> 
> In preparation for removing the <linux/kernel.h> include from
> <linux/list.h>, include the header directly to avoid build errors.
> 
> [...]

Applied, thanks!

[1/1] ARM: i.MX8M: bootrom-cmd: include missing linux/kernel.h header
      https://git.pengutronix.de/cgit/barebox/commit/?id=d8e6b4e9b6de (link may not be stable)

Best regards,
-- 
Sascha Hauer <s.hauer@pengutronix.de>




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-07-24  8:07 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-07-22 16:26 [PATCH] ARM: i.MX8M: bootrom-cmd: include missing linux/kernel.h header Ahmad Fatoum
2024-07-24  8:06 ` Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox