mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH] mci: core: remove reference to SD Card from common mci_card_probe
@ 2024-07-29 19:06 Ahmad Fatoum
  2024-07-30  7:50 ` Sascha Hauer
  0 siblings, 1 reply; 2+ messages in thread
From: Ahmad Fatoum @ 2024-07-29 19:06 UTC (permalink / raw)
  To: barebox; +Cc: Ahmad Fatoum

mci_card_probe is called for both SD cards and MMC, so reporting that
an SD Card was successfully added is misleading.

There is an info message that reports whether it's a MMC or SD card
already, so just remove the SD from this last debug print.

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 drivers/mci/mci-core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mci/mci-core.c b/drivers/mci/mci-core.c
index 200b23ffb604..c7e3c4b6976d 100644
--- a/drivers/mci/mci-core.c
+++ b/drivers/mci/mci-core.c
@@ -2784,7 +2784,7 @@ static int mci_card_probe(struct mci *mci)
 
 	mci_parse_cid(mci);
 
-	dev_dbg(&mci->dev, "SD Card successfully added\n");
+	dev_dbg(&mci->dev, "Card successfully added\n");
 
 on_error:
 	if (rc != 0) {
-- 
2.39.2




^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] mci: core: remove reference to SD Card from common mci_card_probe
  2024-07-29 19:06 [PATCH] mci: core: remove reference to SD Card from common mci_card_probe Ahmad Fatoum
@ 2024-07-30  7:50 ` Sascha Hauer
  0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2024-07-30  7:50 UTC (permalink / raw)
  To: barebox, Ahmad Fatoum


On Mon, 29 Jul 2024 21:06:53 +0200, Ahmad Fatoum wrote:
> mci_card_probe is called for both SD cards and MMC, so reporting that
> an SD Card was successfully added is misleading.
> 
> There is an info message that reports whether it's a MMC or SD card
> already, so just remove the SD from this last debug print.
> 
> 
> [...]

Applied, thanks!

[1/1] mci: core: remove reference to SD Card from common mci_card_probe
      https://git.pengutronix.de/cgit/barebox/commit/?id=2d6087614fed (link may not be stable)

Best regards,
-- 
Sascha Hauer <s.hauer@pengutronix.de>




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-07-30  7:51 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-07-29 19:06 [PATCH] mci: core: remove reference to SD Card from common mci_card_probe Ahmad Fatoum
2024-07-30  7:50 ` Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox