mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH] bbu: report what device caused the handler to be unavailble
@ 2024-07-29 14:32 Ahmad Fatoum
  2024-07-30  7:52 ` Sascha Hauer
  0 siblings, 1 reply; 2+ messages in thread
From: Ahmad Fatoum @ 2024-07-29 14:32 UTC (permalink / raw)
  To: barebox; +Cc: Ahmad Fatoum

The current message only lists the handler name, but to understand why
the operation failed, it's useful to print also the path of the device
that wasn't found. Change the info message to list both.

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 common/bbu.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/common/bbu.c b/common/bbu.c
index ba2566acdfad..f71747aa2f6d 100644
--- a/common/bbu.c
+++ b/common/bbu.c
@@ -55,8 +55,8 @@ void bbu_append_handlers_to_file_list(struct file_list *files)
 		if (stat(devpath, &s) == 0) {
 			append_bbu_entry(handler->name, devpath, files);
 		} else {
-			pr_info("Skipping unavailable handler bbu-%s\n",
-				handler->name);
+			pr_info("Skipping handler bbu-%s: %s unavailable\n",
+				handler->name, devpath);
 		}
 
 		free(devpath);
-- 
2.39.2




^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] bbu: report what device caused the handler to be unavailble
  2024-07-29 14:32 [PATCH] bbu: report what device caused the handler to be unavailble Ahmad Fatoum
@ 2024-07-30  7:52 ` Sascha Hauer
  0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2024-07-30  7:52 UTC (permalink / raw)
  To: barebox, Ahmad Fatoum


On Mon, 29 Jul 2024 16:32:33 +0200, Ahmad Fatoum wrote:
> The current message only lists the handler name, but to understand why
> the operation failed, it's useful to print also the path of the device
> that wasn't found. Change the info message to list both.
> 
> 

Applied, thanks!

[1/1] bbu: report what device caused the handler to be unavailble
      https://git.pengutronix.de/cgit/barebox/commit/?id=64905c7496aa (link may not be stable)

Best regards,
-- 
Sascha Hauer <s.hauer@pengutronix.de>




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-07-30  7:53 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-07-29 14:32 [PATCH] bbu: report what device caused the handler to be unavailble Ahmad Fatoum
2024-07-30  7:52 ` Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox