mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH] fs: ramfs: simplify len calculation in ramfs_find_chunk
@ 2024-07-24  9:09 Ahmad Fatoum
  2024-07-30  8:17 ` Sascha Hauer
  0 siblings, 1 reply; 2+ messages in thread
From: Ahmad Fatoum @ 2024-07-24  9:09 UTC (permalink / raw)
  To: barebox; +Cc: Ahmad Fatoum

ramfs_find_chunk finds the correct chunk and additionally returns via
argument pointers the offset to use and the remaining length.

While correct, the way the remaining len is calculated can be simplified
by using the offset previously calculated:

  data->ofs  +        data->size - pos
  data->size -  pos + data->ofs
  data->size - (pos - data->ofs)
  data->size - (*ofs)

Do that for clarity. No functional change.

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 fs/ramfs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/ramfs.c b/fs/ramfs.c
index 3223beba7212..a799b23efbcd 100644
--- a/fs/ramfs.c
+++ b/fs/ramfs.c
@@ -202,7 +202,7 @@ static struct ramfs_chunk *ramfs_find_chunk(struct ramfs_inode *node,
 	list_for_each_entry_from(data, &node->data, list) {
 		if (data->ofs + data->size > pos) {
 			*ofs = pos - data->ofs;
-			*len = data->ofs + data->size - pos;
+			*len = data->size - *ofs;
 
 			node->current_chunk = data;
 
-- 
2.39.2




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-07-30  8:17 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-07-24  9:09 [PATCH] fs: ramfs: simplify len calculation in ramfs_find_chunk Ahmad Fatoum
2024-07-30  8:17 ` Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox