From: Sascha Hauer <s.hauer@pengutronix.de>
To: barebox@lists.infradead.org, Richard Weinberger <richard@nod.at>
Cc: upstream+barebox@sigma-star.at
Subject: Re: [PATCH] ext4: Fix integer overflow in ext4fs_read_symlink()
Date: Tue, 30 Jul 2024 11:32:37 +0200 [thread overview]
Message-ID: <172233195745.1382929.12988670780161115293.b4-ty@pengutronix.de> (raw)
In-Reply-To: <20240702194427.936-1-richard@nod.at>
On Tue, 02 Jul 2024 21:44:27 +0200, Richard Weinberger wrote:
> While zalloc() takes a size_t type, adding 1 to the le32 variable
> will overflow.
> A carefully crafted ext4 filesystem can exhibit an inode size of 0xffffffff
> and as consequence zalloc() will do a zero allocation.
>
> Later in the function the inode size is again used for copying data.
> So an attacker can overwrite memory.
>
> [...]
Applied, thanks!
[1/1] ext4: Fix integer overflow in ext4fs_read_symlink()
https://git.pengutronix.de/cgit/barebox/commit/?id=a2b76550f7d8 (link may not be stable)
Best regards,
--
Sascha Hauer <s.hauer@pengutronix.de>
prev parent reply other threads:[~2024-07-30 9:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-02 19:44 Richard Weinberger
2024-07-17 6:17 ` Ahmad Fatoum
2024-07-30 9:32 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=172233195745.1382929.12988670780161115293.b4-ty@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=richard@nod.at \
--cc=upstream+barebox@sigma-star.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox