* [PATCH] fixup! console: add new CONSOLE_ACTIVATE_ALL_FALLBACK option
@ 2024-08-05 16:28 Ahmad Fatoum
2024-08-06 5:54 ` Sascha Hauer
0 siblings, 1 reply; 2+ messages in thread
From: Ahmad Fatoum @ 2024-08-05 16:28 UTC (permalink / raw)
To: barebox; +Cc: Ahmad Fatoum
console: fix CONSOLE_ACTIVATE_ALL_FALLBACK initcall enablement
This used to be enabled unconditionally and when the #ifdef was added,
it checked a never-defined symbol. Add the CONFIG_ prefix to fix this.
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
common/console.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common/console.c b/common/console.c
index 310959eeb8b4..136ed3b59803 100644
--- a/common/console.c
+++ b/common/console.c
@@ -480,7 +480,7 @@ static __maybe_unused int console_activate_all_fallback(void)
return 0;
}
-#ifdef CONSOLE_ACTIVATE_ALL_FALLBACK
+#ifdef CONFIG_CONSOLE_ACTIVATE_ALL_FALLBACK
postenvironment_initcall(console_activate_all_fallback);
#endif
--
2.39.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] fixup! console: add new CONSOLE_ACTIVATE_ALL_FALLBACK option
2024-08-05 16:28 [PATCH] fixup! console: add new CONSOLE_ACTIVATE_ALL_FALLBACK option Ahmad Fatoum
@ 2024-08-06 5:54 ` Sascha Hauer
0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2024-08-06 5:54 UTC (permalink / raw)
To: barebox, Ahmad Fatoum
On Mon, 05 Aug 2024 18:28:09 +0200, Ahmad Fatoum wrote:
> console: fix CONSOLE_ACTIVATE_ALL_FALLBACK initcall enablement
>
> This used to be enabled unconditionally and when the #ifdef was added,
> it checked a never-defined symbol. Add the CONFIG_ prefix to fix this.
>
>
Applied, thanks!
[1/1] fixup! console: add new CONSOLE_ACTIVATE_ALL_FALLBACK option
https://git.pengutronix.de/cgit/barebox/commit/?id=4f4e5624b851 (link may not be stable)
Best regards,
--
Sascha Hauer <s.hauer@pengutronix.de>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-08-06 5:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-08-05 16:28 [PATCH] fixup! console: add new CONSOLE_ACTIVATE_ALL_FALLBACK option Ahmad Fatoum
2024-08-06 5:54 ` Sascha Hauer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox