* [PATCH] ARM: rockchip: dmc: reduce number of leading zeroes
@ 2024-08-05 15:35 Ahmad Fatoum
2024-08-06 5:55 ` Sascha Hauer
0 siblings, 1 reply; 2+ messages in thread
From: Ahmad Fatoum @ 2024-08-05 15:35 UTC (permalink / raw)
To: barebox; +Cc: Ahmad Fatoum
Driver probe currently results in:
rockchip-dmc memory-controller.of: Detected memory size: 0x0000000080000000
which while correct is a bit hard to read, because of the number
of zeroes. Make it a bit more readable by showing zeroes to the left
only if the size up to 4G. This would turn the above into a more
readable:
rockchip-dmc memory-controller.of: Detected memory size: 0x80000000
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
arch/arm/mach-rockchip/dmc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-rockchip/dmc.c b/arch/arm/mach-rockchip/dmc.c
index 6bc9d9aabc94..81c7e2649e7f 100644
--- a/arch/arm/mach-rockchip/dmc.c
+++ b/arch/arm/mach-rockchip/dmc.c
@@ -206,7 +206,7 @@ static int rockchip_dmc_probe(struct device *dev)
memsize += rockchip_sdram_size(sys_rega, sys_regb);
}
- dev_info(dev, "Detected memory size: %pa\n", &memsize);
+ dev_info(dev, "Detected memory size: 0x%08llx\n", (u64)memsize);
/* lowest 10M are shaved off for secure world firmware */
membase = 0xa00000;
--
2.39.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] ARM: rockchip: dmc: reduce number of leading zeroes
2024-08-05 15:35 [PATCH] ARM: rockchip: dmc: reduce number of leading zeroes Ahmad Fatoum
@ 2024-08-06 5:55 ` Sascha Hauer
0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2024-08-06 5:55 UTC (permalink / raw)
To: barebox, Ahmad Fatoum
On Mon, 05 Aug 2024 17:35:21 +0200, Ahmad Fatoum wrote:
> Driver probe currently results in:
>
> rockchip-dmc memory-controller.of: Detected memory size: 0x0000000080000000
>
> which while correct is a bit hard to read, because of the number
> of zeroes. Make it a bit more readable by showing zeroes to the left
> only if the size up to 4G. This would turn the above into a more
> readable:
>
> [...]
Applied, thanks!
[1/1] ARM: rockchip: dmc: reduce number of leading zeroes
https://git.pengutronix.de/cgit/barebox/commit/?id=eea0fa6f5d4f (link may not be stable)
Best regards,
--
Sascha Hauer <s.hauer@pengutronix.de>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-08-06 5:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-08-05 15:35 [PATCH] ARM: rockchip: dmc: reduce number of leading zeroes Ahmad Fatoum
2024-08-06 5:55 ` Sascha Hauer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox