From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from s36.web-servers.com.au ([118.127.46.63]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1Zese3-0004yw-Te for barebox@lists.infradead.org; Wed, 23 Sep 2015 22:36:12 +0000 From: Marc Reilly Date: Thu, 24 Sep 2015 08:35:54 +1000 Message-ID: <1724333.SSeDMqRqa0@dev2> In-Reply-To: <1443021836-10430-1-git-send-email-s.hauer@pengutronix.de> References: <1443021836-10430-1-git-send-email-s.hauer@pengutronix.de> MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "barebox" Errors-To: barebox-bounces+u.kleine-koenig=pengutronix.de@lists.infradead.org Subject: Re: [PATCH] of_fix_tree: fo not fail when fixup fails To: barebox@lists.infradead.org Hi, Should the subject be "do not fail .." (s/fo/do) ? Cheers, Marc On Wednesday, September 23, 2015 05:23:56 PM Sascha Hauer wrote: > When a device tree fixup fails it is worth printing a warning, but > we should not fail booting. > > Signed-off-by: Sascha Hauer > --- > common/oftree.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/common/oftree.c b/common/oftree.c > index cafe46c..d408f14 100644 > --- a/common/oftree.c > +++ b/common/oftree.c > @@ -189,11 +189,9 @@ int of_fix_tree(struct device_node *node) > > list_for_each_entry(of_fixup, &of_fixup_list, list) { > ret = of_fixup->fixup(node, of_fixup->context); > - if (ret) { > - pr_err("Failed to fixup node in %pS: %s\n", > + if (ret) > + pr_warn("Failed to fixup node in %pS: %s\n", > of_fixup->fixup, strerror(-ret)); > - return ret; > - } > } > > return 0; _______________________________________________ barebox mailing list barebox@lists.infradead.org http://lists.infradead.org/mailman/listinfo/barebox