mail archive of the barebox mailing list
 help / color / mirror / Atom feed
* [PATCH] ARM: socfpga: drop unused Arria 10 barebox-arm-head.h
@ 2024-08-22 11:54 Ahmad Fatoum
  2024-08-23  8:04 ` Sascha Hauer
  2024-08-26 11:06 ` Sascha Hauer
  0 siblings, 2 replies; 3+ messages in thread
From: Ahmad Fatoum @ 2024-08-22 11:54 UTC (permalink / raw)
  To: barebox; +Cc: Steffen Trumtrar

From: Ahmad Fatoum <ahmad@a3f.at>

The file is unreferenced anywhere and it doesn't differ from the default
__barebox_arm_head anyway, except by two additional words with value
0x55555555, which shouldn't matter.

It thus seems that the file wasn't needed when it was first added and
it's surely not needed now as it has been unreferenced for more than a
year.

Fixes: d5c8bc3ff1a7 ("ARM: socfpga: add arria10 support")
Cc: Steffen Trumtrar <s.trumtrar@pengutronix.de>
Signed-off-by: Ahmad Fatoum <ahmad@a3f.at>
---
 include/mach/socfpga/barebox-arm-head.h | 37 -------------------------
 1 file changed, 37 deletions(-)
 delete mode 100644 include/mach/socfpga/barebox-arm-head.h

diff --git a/include/mach/socfpga/barebox-arm-head.h b/include/mach/socfpga/barebox-arm-head.h
deleted file mode 100644
index eff05b0e41fd..000000000000
--- a/include/mach/socfpga/barebox-arm-head.h
+++ /dev/null
@@ -1,37 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0-only */
-
-static inline void __barebox_arm_head(void)
-{
-	__asm__ __volatile__ (
-#ifdef CONFIG_THUMB2_BAREBOX
-		".arm\n"
-		"adr r9, 1f + 1\n"
-		"bx r9\n"
-		".thumb\n"
-		"1:\n"
-		"bl 2f\n"
-		".rept 10\n"
-		"1: b 1b\n"
-		".endr\n"
-#else
-		"b 2f\n"
-		"1: b 1b\n"
-		"1: b 1b\n"
-		"1: b 1b\n"
-		"1: b 1b\n"
-		"1: b 1b\n"
-		"1: b 1b\n"
-		"1: b 1b\n"
-#endif
-		".asciz \"barebox\"\n"
-		".word _text\n"				/* text base. If copied there,
-							 * barebox can skip relocation
-							 */
-		".word _barebox_image_size\n"		/* image size to copy */
-
-		".rept 10\n"
-		".word 0x55555555\n"
-		".endr\n"
-		"2:\n"
-	);
-}
-- 
2.39.2




^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ARM: socfpga: drop unused Arria 10 barebox-arm-head.h
  2024-08-22 11:54 [PATCH] ARM: socfpga: drop unused Arria 10 barebox-arm-head.h Ahmad Fatoum
@ 2024-08-23  8:04 ` Sascha Hauer
  2024-08-26 11:06 ` Sascha Hauer
  1 sibling, 0 replies; 3+ messages in thread
From: Sascha Hauer @ 2024-08-23  8:04 UTC (permalink / raw)
  To: barebox, Ahmad Fatoum; +Cc: Steffen Trumtrar


On Thu, 22 Aug 2024 13:54:20 +0200, Ahmad Fatoum wrote:
> The file is unreferenced anywhere and it doesn't differ from the default
> __barebox_arm_head anyway, except by two additional words with value
> 0x55555555, which shouldn't matter.
> 
> It thus seems that the file wasn't needed when it was first added and
> it's surely not needed now as it has been unreferenced for more than a
> year.
> 
> [...]

Applied, thanks!

[1/1] ARM: socfpga: drop unused Arria 10 barebox-arm-head.h
      https://git.pengutronix.de/cgit/barebox/commit/?id=33908299f1d1 (link may not be stable)

Best regards,
-- 
Sascha Hauer <s.hauer@pengutronix.de>




^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ARM: socfpga: drop unused Arria 10 barebox-arm-head.h
  2024-08-22 11:54 [PATCH] ARM: socfpga: drop unused Arria 10 barebox-arm-head.h Ahmad Fatoum
  2024-08-23  8:04 ` Sascha Hauer
@ 2024-08-26 11:06 ` Sascha Hauer
  1 sibling, 0 replies; 3+ messages in thread
From: Sascha Hauer @ 2024-08-26 11:06 UTC (permalink / raw)
  To: barebox, Ahmad Fatoum; +Cc: Steffen Trumtrar


On Thu, 22 Aug 2024 13:54:20 +0200, Ahmad Fatoum wrote:
> The file is unreferenced anywhere and it doesn't differ from the default
> __barebox_arm_head anyway, except by two additional words with value
> 0x55555555, which shouldn't matter.
> 
> It thus seems that the file wasn't needed when it was first added and
> it's surely not needed now as it has been unreferenced for more than a
> year.
> 
> [...]

Applied, thanks!

[1/1] ARM: socfpga: drop unused Arria 10 barebox-arm-head.h
      https://git.pengutronix.de/cgit/barebox/commit/?id=33908299f1d1 (link may not be stable)

Best regards,
-- 
Sascha Hauer <s.hauer@pengutronix.de>




^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-08-26 11:09 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-08-22 11:54 [PATCH] ARM: socfpga: drop unused Arria 10 barebox-arm-head.h Ahmad Fatoum
2024-08-23  8:04 ` Sascha Hauer
2024-08-26 11:06 ` Sascha Hauer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox