From: Sascha Hauer <s.hauer@pengutronix.de>
To: Barebox List <barebox@lists.infradead.org>,
Sascha Hauer <s.hauer@pengutronix.de>
Cc: afa@pengutronix.de
Subject: Re: [PATCH] mci: Fix erase_grp_size extraction for SD with csd_struct v0
Date: Tue, 01 Oct 2024 12:33:43 +0200 [thread overview]
Message-ID: <172777882337.1032086.365231160353899463.b4-ty@pengutronix.de> (raw)
In-Reply-To: <20241001095741.920605-1-s.hauer@pengutronix.de>
On Tue, 01 Oct 2024 11:57:41 +0200, Sascha Hauer wrote:
> In mci_extract_erase_group_size() we test for (IS_SD() && csd_struct_v1)
> which means that for non csd_struct_v1 SD cards we fall into the MMC
> path and evaluate ext_csd. This doesn't exist for SD cards and the
> code crashes with a NULL pointer deref.
>
> Fix this by always falling into the SD case for SD cards. Add the
> missing erase_grp_size extraction for csd_struct v0 cards. The code
> for that is taken from the corresponding Linux code.
>
> [...]
Applied, thanks!
[1/1] mci: Fix erase_grp_size extraction for SD with csd_struct v0
https://git.pengutronix.de/cgit/barebox/commit/?id=98bd0bee79f4 (link may not be stable)
Best regards,
--
Sascha Hauer <s.hauer@pengutronix.de>
prev parent reply other threads:[~2024-10-01 10:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-01 9:57 Sascha Hauer
2024-10-01 10:09 ` Ahmad Fatoum
2024-10-01 10:33 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=172777882337.1032086.365231160353899463.b4-ty@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=afa@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox