[PATCH 1/2] fixup! video: add dw-hdmi driver

[PATCH 1/2] fixup! video: add dw-hdmi driver

[Ahmad Fatoum]

video: dw-hdmi: drop never defined dw_hdmi_remove

Building without linker garbage collection triggers an error, because
dw_hdmi_remove is never defined.

We remove it, but keep dw_hdmi_unbind as a dummy function as it can
be called by other drivers and then we could make it do something
useful in future.

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 drivers/video/dw-hdmi.c | 1 -
 include/video/dw_hdmi.h | 1 -
 2 files changed, 2 deletions(-)

diff --git a/drivers/video/dw-hdmi.c b/drivers/video/dw-hdmi.c
index 2e9f21332c2e..ac4f368f6369 100644
--- a/drivers/video/dw-hdmi.c
+++ b/drivers/video/dw-hdmi.c
@@ -2273,7 +2273,6 @@ EXPORT_SYMBOL_GPL(dw_hdmi_bind);
 
 void dw_hdmi_unbind(struct dw_hdmi *hdmi)
 {
-	dw_hdmi_remove(hdmi);
 }
 EXPORT_SYMBOL_GPL(dw_hdmi_unbind);
 
diff --git a/include/video/dw_hdmi.h b/include/video/dw_hdmi.h
index c7a2ee338160..b2831e60b9ff 100644
--- a/include/video/dw_hdmi.h
+++ b/include/video/dw_hdmi.h
@@ -168,7 +168,6 @@ struct dw_hdmi_plat_data {
 
 struct dw_hdmi *dw_hdmi_probe(struct device *dev,
 			      const struct dw_hdmi_plat_data *plat_data);
-void dw_hdmi_remove(struct dw_hdmi *hdmi);
 void dw_hdmi_unbind(struct dw_hdmi *hdmi);
 struct dw_hdmi *dw_hdmi_bind(struct device *dev,
 			     const struct dw_hdmi_plat_data *plat_data);
-- 
2.39.5

[PATCH 2/2] fixup! video: add dw-hdmi driver

[Ahmad Fatoum]

video: dw-hdmi: fix compile testing with CONFIG_SANDBOX

Building under sandbox results in an error message due to missing
definition of ARRAY_SIZE. Fix this by including the relevant header.

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 drivers/video/dw-hdmi.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/video/dw-hdmi.c b/drivers/video/dw-hdmi.c
index ac4f368f6369..73201836b7e5 100644
--- a/drivers/video/dw-hdmi.c
+++ b/drivers/video/dw-hdmi.c
@@ -7,6 +7,7 @@
  * Copyright (C) 2010, Guennadi Liakhovetski <g.liakhovetski@gmx.de>
  */
 #include <linux/clk.h>
+#include <linux/kernel.h>
 #include <linux/err.h>
 #include <linux/hdmi.h>
 #include <i2c/i2c.h>
-- 
2.39.5

Re: [PATCH 1/2] fixup! video: add dw-hdmi driver

[Sascha Hauer]

On Mon, 14 Oct 2024 12:46:43 +0200, Ahmad Fatoum wrote:
> video: dw-hdmi: drop never defined dw_hdmi_remove
> 
> Building without linker garbage collection triggers an error, because
> dw_hdmi_remove is never defined.
> 
> We remove it, but keep dw_hdmi_unbind as a dummy function as it can
> be called by other drivers and then we could make it do something
> useful in future.
> 
> [...]

Applied, thanks!

[1/2] fixup! video: add dw-hdmi driver
      https://git.pengutronix.de/cgit/barebox/commit/?id=3f61bbe2b1f4 (link may not be stable)
[2/2] fixup! video: add dw-hdmi driver
      https://git.pengutronix.de/cgit/barebox/commit/?id=3f61bbe2b1f4 (link may not be stable)

Best regards,
-- 
Sascha Hauer <s.hauer@pengutronix.de>