[PATCH master v2 1/2] sandbox: noshell_defconfig: set CONFIG_CONSOLE_DISABLE_INPUT=y

[PATCH master v2 1/2] sandbox: noshell_defconfig: set CONFIG_CONSOLE_DISABLE_INPUT=y

[Ahmad Fatoum]

We are currently disabling CONFIG_DISABLE_INPUT, which is non-existent
option. It makes sense to _enable_ the option though after fixing the
typo, to get more coverage.

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
v1 -> v2:
  - no change
---
 common/boards/configs/noshell.config | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/common/boards/configs/noshell.config b/common/boards/configs/noshell.config
index 4696a1b3f971..3a91187f9188 100644
--- a/common/boards/configs/noshell.config
+++ b/common/boards/configs/noshell.config
@@ -1,2 +1,2 @@
 CONFIG_SHELL_NONE=y
-# CONFIG_DISABLE_INPUT is not set
+CONFIG_CONSOLE_DISABLE_INPUT=y
-- 
2.39.5

[PATCH master v2 2/2] startup: do not bring up networking if console input disabled

[Ahmad Fatoum]

Bringing up network interfaces is a development convenience.
If barebox is configured not to enable any console input by default,
we shouldn't bring up the network interfaces automatically either.

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
v1 -> v2:
  - commit message adjusted: DHCP isn't attempted in eth_open_all by
    default, just network links are brought up.
---
 common/startup.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/common/startup.c b/common/startup.c
index 9510824a908a..d71d83c221dc 100644
--- a/common/startup.c
+++ b/common/startup.c
@@ -315,7 +315,7 @@ static int run_init(void)
 	if (autoboot == AUTOBOOT_BOOT)
 		run_command("boot");
 
-	if (IS_ENABLED(CONFIG_NET))
+	if (IS_ENABLED(CONFIG_NET) && !IS_ENABLED(CONFIG_CONSOLE_DISABLE_INPUT))
 		eth_open_all();
 
 	if (autoboot == AUTOBOOT_MENU)
-- 
2.39.5

Re: [PATCH master v2 1/2] sandbox: noshell_defconfig: set CONFIG_CONSOLE_DISABLE_INPUT=y

[Sascha Hauer]

On Fri, 22 Nov 2024 17:23:20 +0100, Ahmad Fatoum wrote:
> We are currently disabling CONFIG_DISABLE_INPUT, which is non-existent
> option. It makes sense to _enable_ the option though after fixing the
> typo, to get more coverage.
> 
> 

Applied, thanks!

[1/2] sandbox: noshell_defconfig: set CONFIG_CONSOLE_DISABLE_INPUT=y
      https://git.pengutronix.de/cgit/barebox/commit/?id=5fb7dda6b1e0 (link may not be stable)
[2/2] startup: do not bring up networking if console input disabled
      https://git.pengutronix.de/cgit/barebox/commit/?id=8637b876fb16 (link may not be stable)

Best regards,
-- 
Sascha Hauer <s.hauer@pengutronix.de>