From: Sascha Hauer <s.hauer@pengutronix.de>
To: barebox@lists.infradead.org, Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: Re: [PATCH master] net: tap: return -ENODEV when TAP permission is denied
Date: Thu, 12 Dec 2024 09:18:51 +0100 [thread overview]
Message-ID: <173399153177.2972543.14297781876849779354.b4-ty@pengutronix.de> (raw)
In-Reply-To: <20241212072228.2468741-1-a.fatoum@pengutronix.de>
On Thu, 12 Dec 2024 08:22:28 +0100, Ahmad Fatoum wrote:
> tap_alloc will return -EPERM, when not running with CAP_NET_ADMIN.
> For most users, this is the default case and thus barebox printing:
>
> could not get tap device: Operation not permitted
> ERROR: tap tap0: probe failed: Operation not permitted
>
> is just confusing. Improve this by returning -ENODEV in that situation
> instead, which driver core already understands to be an acceptable
> return code that warrants no error message.
>
> [...]
Applied, thanks!
[1/1] net: tap: return -ENODEV when TAP permission is denied
https://git.pengutronix.de/cgit/barebox/commit/?id=7ddffa986081 (link may not be stable)
Best regards,
--
Sascha Hauer <s.hauer@pengutronix.de>
prev parent reply other threads:[~2024-12-12 8:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-12 7:22 Ahmad Fatoum
2024-12-12 8:18 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=173399153177.2972543.14297781876849779354.b4-ty@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox