[PATCH] video: mipi_dbi: fix swapped width and height in mipi_dbi_blank

[PATCH] video: mipi_dbi: fix swapped width and height in mipi_dbi_blank

[Sven Püschel]

Fix swapped width and height values in the mipi_dbi_blank function. This
caused a non quadratic display not being cleared entirely when disabling
the framebuffer device.

Signed-off-by: Sven Püschel <s.pueschel@pengutronix.de>
---
 drivers/video/mipi_dbi.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/video/mipi_dbi.c b/drivers/video/mipi_dbi.c
index c202ecc1c7..1e2883020b 100644
--- a/drivers/video/mipi_dbi.c
+++ b/drivers/video/mipi_dbi.c
@@ -307,8 +307,8 @@ EXPORT_SYMBOL(mipi_dbi_enable_flush);
 
 static void mipi_dbi_blank(struct mipi_dbi_dev *dbidev)
 {
-	u16 height = dbidev->mode.xres;
-	u16 width = dbidev->mode.yres;
+	u16 height = dbidev->mode.yres;
+	u16 width = dbidev->mode.xres;
 	struct mipi_dbi *dbi = &dbidev->dbi;
 	size_t len = width * height * 2;
 
-- 
2.39.5

Re: [PATCH] video: mipi_dbi: fix swapped width and height in mipi_dbi_blank

[Ahmad Fatoum]

On 10.12.24 09:05, Sven Püschel wrote:
> Fix swapped width and height values in the mipi_dbi_blank function. This
> caused a non quadratic display not being cleared entirely when disabling
> the framebuffer device.
> 
> Signed-off-by: Sven Püschel <s.pueschel@pengutronix.de>

Reviewed-by: Ahmad Fatoum <a.fatoum@pengutronix.de>

Good catch, thanks,
Ahmad

> ---
>  drivers/video/mipi_dbi.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/video/mipi_dbi.c b/drivers/video/mipi_dbi.c
> index c202ecc1c7..1e2883020b 100644
> --- a/drivers/video/mipi_dbi.c
> +++ b/drivers/video/mipi_dbi.c
> @@ -307,8 +307,8 @@ EXPORT_SYMBOL(mipi_dbi_enable_flush);
>  
>  static void mipi_dbi_blank(struct mipi_dbi_dev *dbidev)
>  {
> -	u16 height = dbidev->mode.xres;
> -	u16 width = dbidev->mode.yres;
> +	u16 height = dbidev->mode.yres;
> +	u16 width = dbidev->mode.xres;
>  	struct mipi_dbi *dbi = &dbidev->dbi;
>  	size_t len = width * height * 2;
>  


-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

Re: [PATCH] video: mipi_dbi: fix swapped width and height in mipi_dbi_blank

[Sascha Hauer]

On Tue, 10 Dec 2024 09:05:19 +0100, Sven Püschel wrote:
> Fix swapped width and height values in the mipi_dbi_blank function. This
> caused a non quadratic display not being cleared entirely when disabling
> the framebuffer device.
> 
> 

Applied, thanks!

[1/1] video: mipi_dbi: fix swapped width and height in mipi_dbi_blank
      https://git.pengutronix.de/cgit/barebox/commit/?id=947af7032a73 (link may not be stable)

Best regards,
-- 
Sascha Hauer <s.hauer@pengutronix.de>