From: Sascha Hauer <s.hauer@pengutronix.de>
To: barebox@lists.infradead.org, Lucas Stach <dev@lynxeye.de>
Subject: Re: [PATCH] mci: sdhci: initialize dma state on non-data commands
Date: Mon, 16 Dec 2024 09:29:21 +0100 [thread overview]
Message-ID: <173433776107.1471330.15629280685433372007.b4-ty@pengutronix.de> (raw)
In-Reply-To: <20241213205815.356903-1-dev@lynxeye.de>
On Fri, 13 Dec 2024 21:58:15 +0100, Lucas Stach wrote:
> Commands without data will leave the dma parameter uninitialized
> in sdhci_setup_data_dma(). Drivers then decide whether to set
> SDHCI_DMA_EN based on this uninitialized data. This seems to be
> mostly harmless as the host controllers seem to ignore this bit
> on non-data commands, but it's still a bit confusing. Make sure
> to always return a valid state.
>
> [...]
Applied, thanks!
[1/1] mci: sdhci: initialize dma state on non-data commands
https://git.pengutronix.de/cgit/barebox/commit/?id=ce07b7ed0266 (link may not be stable)
Best regards,
--
Sascha Hauer <s.hauer@pengutronix.de>
prev parent reply other threads:[~2024-12-16 8:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-13 20:58 Lucas Stach
2024-12-16 8:29 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=173433776107.1471330.15629280685433372007.b4-ty@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=dev@lynxeye.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox