From: Sascha Hauer <s.hauer@pengutronix.de>
To: barebox@lists.infradead.org, Lucas Stach <dev@lynxeye.de>
Subject: Re: [PATCH] environment: don't return raw device when file-path is specified
Date: Fri, 20 Dec 2024 10:04:38 +0100 [thread overview]
Message-ID: <173468547829.3155194.2476662951101841099.b4-ty@pengutronix.de> (raw)
In-Reply-To: <20241213150855.263388-1-dev@lynxeye.de>
On Fri, 13 Dec 2024 16:08:55 +0100, Lucas Stach wrote:
> Environment nodes that specify the file-path property expect the
> environment to be stored in a file system.
>
> Returning the raw device path when CONFIG_OF_BAREBOX_ENV_IN_FS is
> disabled in such a case is not a good idea, as saving the env may
> then unexpectedly overwrite unrelated device content. Bail out in
> case a file-path is specified, but we have no env in FS support.
>
> [...]
Applied, thanks!
[1/1] environment: don't return raw device when file-path is specified
https://git.pengutronix.de/cgit/barebox/commit/?id=f4283f6d9f15 (link may not be stable)
Best regards,
--
Sascha Hauer <s.hauer@pengutronix.de>
prev parent reply other threads:[~2024-12-20 9:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-13 15:08 Lucas Stach
2024-12-20 9:04 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=173468547829.3155194.2476662951101841099.b4-ty@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=dev@lynxeye.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox