From: Sascha Hauer <s.hauer@pengutronix.de>
To: barebox@lists.infradead.org, Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: "Khem Raj" <raj.khem@gmail.com>, "Enrico Jörns" <ejo@pengutronix.de>
Subject: Re: [PATCH RFT v3] scripts: define _GNU_SOURCE for all source files
Date: Tue, 28 Jan 2025 11:05:26 +0100 [thread overview]
Message-ID: <173805872609.507867.4394905453349143893.b4-ty@pengutronix.de> (raw)
In-Reply-To: <20250127195109.3928003-1-a.fatoum@pengutronix.de>
On Mon, 27 Jan 2025 20:51:09 +0100, Ahmad Fatoum wrote:
> musl doesn't define loff_t, unless _GNU_SOURCE is defined, which
> we don't do everywhere and glibc didn't mind.
>
> This led to build errors with musl when code makes it into
> scripts/ that uses loff_t. This was already fixed once e.g. in commit
> c0d065fb0aa0 ("scripts: bareboximd: remove usage of loff_t").
>
> [...]
Applied, thanks!
[1/1] scripts: define _GNU_SOURCE for all source files
https://git.pengutronix.de/cgit/barebox/commit/?id=8ed8a260437b (link may not be stable)
Best regards,
--
Sascha Hauer <s.hauer@pengutronix.de>
next prev parent reply other threads:[~2025-01-28 10:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-27 19:51 Ahmad Fatoum
2025-01-27 20:00 ` Khem Raj
2025-01-27 20:15 ` Ahmad Fatoum
2025-01-28 10:05 ` Sascha Hauer [this message]
2025-01-28 11:28 ` Enrico Jörns
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=173805872609.507867.4394905453349143893.b4-ty@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=a.fatoum@pengutronix.de \
--cc=barebox@lists.infradead.org \
--cc=ejo@pengutronix.de \
--cc=raj.khem@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox