* [PATCH] usb: dwc3: fix use of bool for prompt choice
@ 2025-02-17 9:59 Ahmad Fatoum
2025-02-17 10:56 ` Sascha Hauer
0 siblings, 1 reply; 2+ messages in thread
From: Ahmad Fatoum @ 2025-02-17 9:59 UTC (permalink / raw)
To: barebox; +Cc: Ahmad Fatoum
A choice has a prompt, but no type. Newer versions of Kconfig will
start throwing an error if this is violated, so fix it in anticipation.
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
drivers/usb/dwc3/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/dwc3/Kconfig b/drivers/usb/dwc3/Kconfig
index ef1f83bef7aa..de5f0ef6f3eb 100644
--- a/drivers/usb/dwc3/Kconfig
+++ b/drivers/usb/dwc3/Kconfig
@@ -15,7 +15,7 @@ config USB_DWC3
if USB_DWC3
choice
- bool "DWC3 Mode Selection"
+ prompt "DWC3 Mode Selection"
config USB_DWC3_HOST
bool "Host only mode"
--
2.39.5
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] usb: dwc3: fix use of bool for prompt choice
2025-02-17 9:59 [PATCH] usb: dwc3: fix use of bool for prompt choice Ahmad Fatoum
@ 2025-02-17 10:56 ` Sascha Hauer
0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2025-02-17 10:56 UTC (permalink / raw)
To: barebox, Ahmad Fatoum
On Mon, 17 Feb 2025 10:59:21 +0100, Ahmad Fatoum wrote:
> A choice has a prompt, but no type. Newer versions of Kconfig will
> start throwing an error if this is violated, so fix it in anticipation.
>
>
Applied, thanks!
[1/1] usb: dwc3: fix use of bool for prompt choice
https://git.pengutronix.de/cgit/barebox/commit/?id=c6b42a370d22 (link may not be stable)
Best regards,
--
Sascha Hauer <s.hauer@pengutronix.de>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-02-17 12:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-02-17 9:59 [PATCH] usb: dwc3: fix use of bool for prompt choice Ahmad Fatoum
2025-02-17 10:56 ` Sascha Hauer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox