* [PATCH] sandbox: configs: disable CONFIG_NET_NETCONSOLE in sandbox_defconfig
@ 2025-02-20 20:27 Ahmad Fatoum
2025-02-21 12:17 ` Sascha Hauer
0 siblings, 1 reply; 2+ messages in thread
From: Ahmad Fatoum @ 2025-02-20 20:27 UTC (permalink / raw)
To: barebox; +Cc: Ahmad Fatoum
Sandbox users can register extra consoles via command-line arguments, so
it makes sense to have CONFIG_CONSOLE_ACTIVATE_ALL enabled.
This also means that users get an ugly error message by default:
ERROR: netconsole: port not set
Avoid this by disabling the netconsole support in the defconfig.
Users willing to configure it can always enable it again.
Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
arch/sandbox/configs/sandbox_defconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/sandbox/configs/sandbox_defconfig b/arch/sandbox/configs/sandbox_defconfig
index a5e0f72c6340..251af8d0ef31 100644
--- a/arch/sandbox/configs/sandbox_defconfig
+++ b/arch/sandbox/configs/sandbox_defconfig
@@ -94,7 +94,6 @@ CONFIG_CMD_SPD_DECODE=y
CONFIG_CMD_SEED=y
CONFIG_NET=y
CONFIG_NET_NFS=y
-CONFIG_NET_NETCONSOLE=y
CONFIG_NET_SNTP=y
CONFIG_NET_FASTBOOT=y
CONFIG_FEATURE_CONTROLLER=y
--
2.39.5
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] sandbox: configs: disable CONFIG_NET_NETCONSOLE in sandbox_defconfig
2025-02-20 20:27 [PATCH] sandbox: configs: disable CONFIG_NET_NETCONSOLE in sandbox_defconfig Ahmad Fatoum
@ 2025-02-21 12:17 ` Sascha Hauer
0 siblings, 0 replies; 2+ messages in thread
From: Sascha Hauer @ 2025-02-21 12:17 UTC (permalink / raw)
To: barebox, Ahmad Fatoum
On Thu, 20 Feb 2025 21:27:23 +0100, Ahmad Fatoum wrote:
> Sandbox users can register extra consoles via command-line arguments, so
> it makes sense to have CONFIG_CONSOLE_ACTIVATE_ALL enabled.
>
> This also means that users get an ugly error message by default:
>
> ERROR: netconsole: port not set
>
> [...]
Applied, thanks!
[1/1] sandbox: configs: disable CONFIG_NET_NETCONSOLE in sandbox_defconfig
https://git.pengutronix.de/cgit/barebox/commit/?id=20876a9ad601 (link may not be stable)
Best regards,
--
Sascha Hauer <s.hauer@pengutronix.de>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-02-21 12:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-02-20 20:27 [PATCH] sandbox: configs: disable CONFIG_NET_NETCONSOLE in sandbox_defconfig Ahmad Fatoum
2025-02-21 12:17 ` Sascha Hauer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox