[PATCH] fixup! commands: ubsan: hide zero division in test

[PATCH] fixup! commands: ubsan: hide zero division in test

[Ahmad Fatoum]

GCC complains that we pass the address of the variable instead of the
    variable itself:

    commands/ubsan.c: In function ‘test_ubsan_divrem_overflow’:
    error: lvalue required in ‘asm’ statement

       63 |         __asm__ ("" : "=r" (var) : "0" (var))
          |         ^~~~~~~
    ./commands/ubsan.c:46:9: note: in expansion of macro ‘OPTIMIZER_HIDE_VAR’
       46 |         OPTIMIZER_HIDE_VAR(&val2);

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 commands/ubsan.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/commands/ubsan.c b/commands/ubsan.c
index 634ab2bc60b2..debd5e2ce7de 100644
--- a/commands/ubsan.c
+++ b/commands/ubsan.c
@@ -43,7 +43,7 @@ static void test_ubsan_divrem_overflow(void)
 	volatile int val = 16;
 	volatile int val2 = 0;
 
-	OPTIMIZER_HIDE_VAR(&val2);
+	OPTIMIZER_HIDE_VAR(val2);
 
 	val /= val2;
 }
-- 
2.39.5

Re: [PATCH] fixup! commands: ubsan: hide zero division in test

[Sascha Hauer]

On Wed, 19 Mar 2025 17:10:56 +0100, Ahmad Fatoum wrote:
> GCC complains that we pass the address of the variable instead of the
>     variable itself:
> 
>     commands/ubsan.c: In function ‘test_ubsan_divrem_overflow’:
>     error: lvalue required in ‘asm’ statement
> 
>        63 |         __asm__ ("" : "=r" (var) : "0" (var))
>           |         ^~~~~~~
>     ./commands/ubsan.c:46:9: note: in expansion of macro ‘OPTIMIZER_HIDE_VAR’
>        46 |         OPTIMIZER_HIDE_VAR(&val2);
> 
> [...]

Applied, thanks!

[1/1] fixup! commands: ubsan: hide zero division in test
      https://git.pengutronix.de/cgit/barebox/commit/?id=85749615acdd (link may not be stable)

Best regards,
-- 
Sascha Hauer <s.hauer@pengutronix.de>